You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: .github/CONTRIBUTING.md
+3-3
Original file line number
Diff line number
Diff line change
@@ -19,7 +19,7 @@ If you'd like to write some code for nf-core/rnavar, the standard workflow is as
19
19
* If there isn't one already, please create one so that others know you're working on this
20
20
2.[Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/rnavar repository](https://github.com/nf-core/rnavar) to your GitHub account
21
21
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
22
-
4. Use `nf-core schema build .` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
22
+
4. Use `nf-core schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
23
23
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged
24
24
25
25
If you're not used to this workflow with git, you can start with some [docs from GitHub](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests) or even their [excellent `git` resources](https://try.github.io/).
@@ -69,7 +69,7 @@ If you wish to contribute a new step, please use the following coding standards:
69
69
2. Write the process block (see below).
70
70
3. Define the output channel if needed (see below).
71
71
4. Add any new flags/options to `nextflow.config` with a default (see below).
72
-
5. Add any new flags/options to `nextflow_schema.json` with help text (with `nf-core schema build .`).
72
+
5. Add any new flags/options to `nextflow_schema.json` with help text (with `nf-core schema build`).
73
73
6. Add any new flags/options to the help message (for integer/text parameters, print to help the corresponding `nextflow.config` parameter).
74
74
7. Add sanity checks for all relevant parameters.
75
75
8. Add any new software to the `scrape_software_versions.py` script in `bin/` and the version command to the `scrape_software_versions` process in `main.nf`.
@@ -83,7 +83,7 @@ If you wish to contribute a new step, please use the following coding standards:
83
83
84
84
Parameters should be initialised / defined with default values in `nextflow.config` under the `params` scope.
85
85
86
-
Once there, use `nf-core schema build .` to add to `nextflow_schema.json`.
86
+
Once there, use `nf-core schema build` to add to `nextflow_schema.json`.
Copy file name to clipboardexpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -18,7 +18,7 @@ Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/rnav
18
18
-[ ] If you've fixed a bug or added code that should be tested, add tests!
19
19
-[ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/rnavar/tree/master/.github/CONTRIBUTING.md)
20
20
-[ ] If necessary, also make a PR on the nf-core/rnavar _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
21
-
-[ ] Make sure your code lints (`nf-core lint .`).
21
+
-[ ] Make sure your code lints (`nf-core lint`).
22
22
-[ ] Ensure the test suite passes (`nextflow run . -profile test,docker`).
23
23
-[ ] Usage Documentation in `docs/usage.md` is updated.
24
24
-[ ] Output Documentation in `docs/output.md` is updated.
2. Install any of [`Docker`](https://docs.docker.com/engine/installation/), [`Singularity`](https://www.sylabs.io/guides/3.0/user-guide/), [`Podman`](https://podman.io/), [`Shifter`](https://nersc.gitlab.io/development/shifter/how-to-use/) or [`Charliecloud`](https://hpc.github.io/charliecloud/) for full pipeline reproducibility _(please only use [`Conda`](https://conda.io/miniconda.html) as a last resort; see [docs](https://nf-co.re/usage/configuration#basic-configuration-profiles))_
Copy file name to clipboardexpand all lines: nextflow_schema.json
+2-2
Original file line number
Diff line number
Diff line change
@@ -18,7 +18,7 @@
18
18
"type": "string",
19
19
"format": "file-path",
20
20
"mimetype": "text/csv",
21
-
"pattern": "\\.csv$",
21
+
"pattern": "^\\S+\\.csv$",
22
22
"schema": "assets/schema_input.json",
23
23
"description": "Path to comma-separated file containing information about the samples in the experiment.",
24
24
"help_text": "You will need to create a design file with information about the samples in your experiment before running the pipeline. Use this parameter to specify its location. It has to be a comma-separated file with 3 columns, and a header row. See [usage docs](https://nf-co.re/rnavar/usage#samplesheet-input).",
@@ -60,7 +60,7 @@
60
60
"type": "string",
61
61
"format": "file-path",
62
62
"mimetype": "text/plain",
63
-
"pattern": "\\.fn?a(sta)?(\\.gz)?$",
63
+
"pattern": "^\\S+\\.fn?a(sta)?(\\.gz)?$",
64
64
"description": "Path to FASTA genome file.",
65
65
"help_text": "This parameter is *mandatory* if `--genome` is not specified. If you don't have a BWA index available this will be generated for you automatically. Combine with `--save_reference` to save BWA index for future runs.",
0 commit comments