Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 10 Ivy Issue #301

Open
hypertextdevelopers opened this issue Oct 19, 2020 · 2 comments
Open

Angular 10 Ivy Issue #301

hypertextdevelopers opened this issue Oct 19, 2020 · 2 comments
Assignees
Labels
bug effort0: not known (need info) help wanted Need reproduction This issue needs to be reproduced to be approved

Comments

@hypertextdevelopers
Copy link

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

I get this error "This likely means that the library (ngx-smart-modal) which declares NgxSmartModalModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.
" the time I try to run ngx-smart-modal in Angular 10.
Expected behavior

Ngx-smart-modal should have support for Angular 10
Reproduction of the problem

What is the motivation / use case for changing the behavior?

Being up to date with Angular versions
Please tell us about your environment:

OS Catalina, PHPStorm, Yarn

  • Smart Modal version: 0.8.x
  • Angular version: 2.0.x
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all
@KiranShakya
Copy link

ERROR: node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:6:23 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s).

6 static forRoot(): ModuleWithProviders;

node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:10:24 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s).

10 static forChild(): ModuleWithProviders;

These are two things I see when trying to build with this dependency. Previous Angular versions didn't require type definition for ModuleWithProviders.
Hope this info is helpful for creating an Angular Ivy compatible release.

@maximelafarie maximelafarie self-assigned this Oct 21, 2020
@senzacionale
Copy link

Same problem. Any update when new release will be available for Angular 10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug effort0: not known (need info) help wanted Need reproduction This issue needs to be reproduced to be approved
Projects
None yet
Development

No branches or pull requests

4 participants