Skip to content

Commit 82fe326

Browse files
authored
Merge branch 'maximegris:main' into master
2 parents 0b26402 + 05707de commit 82fe326

26 files changed

+12858
-10051
lines changed

.eslintrc.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,18 @@
2020
"createDefaultProgram": true
2121
},
2222
"extends": [
23-
"plugin:@angular-eslint/ng-cli-compat",
24-
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
23+
"plugin:@angular-eslint/recommended",
24+
"eslint:recommended",
25+
"plugin:@typescript-eslint/recommended",
26+
"plugin:@typescript-eslint/recommended-requiring-type-checking",
2527
"plugin:@angular-eslint/template/process-inline-templates"
2628
],
2729
"rules": {
30+
"@typescript-eslint/no-empty-function": 0,
31+
"@typescript-eslint/no-explicit-any": 0,
32+
"@typescript-eslint/no-unsafe-assignment": 0,
33+
"@typescript-eslint/no-unsafe-call": 0,
34+
"@typescript-eslint/no-unsafe-member-access": 0,
2835
"prefer-arrow/prefer-arrow-functions": 0,
2936
"@angular-eslint/directive-selector": 0,
3037
"@angular-eslint/component-selector": [
@@ -34,7 +41,8 @@
3441
"prefix": "app",
3542
"style": "kebab-case"
3643
}
37-
]
44+
],
45+
"jsdoc/newline-after-description": 0
3846
}
3947
},
4048
{
@@ -48,4 +56,4 @@
4856
}
4957
}
5058
]
51-
}
59+
}

.github/workflows/macos.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ on:
1515
workflow_dispatch:
1616

1717
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
18-
permissions:
19-
contents: read
20-
18+
permissions:
19+
contents: read
20+
2121
jobs:
2222
build:
2323
strategy:
2424
matrix:
25-
node-version: [16]
25+
node-version: [18.16]
2626

2727
# The type of runner that the job will run on
2828
runs-on: macos-latest

.github/workflows/ubuntu.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
build:
2020
strategy:
2121
matrix:
22-
node-version: [16]
22+
node-version: [18.16]
2323

2424
# The type of runner that the job will run on
2525
runs-on: ubuntu-18.04

.github/workflows/windows.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ on:
1515
workflow_dispatch:
1616

1717
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
18-
permissions:
19-
contents: read
20-
18+
permissions:
19+
contents: read
20+
2121
jobs:
2222
build:
2323
strategy:
2424
matrix:
25-
node-version: [16]
25+
node-version: [18.16]
2626

2727
# The type of runner that the job will run on
2828
runs-on: windows-latest

.node-version

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
16
1+
18

CHANGELOG.md

+25
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,30 @@
1+
## 13.0.0 (2023-06-30)
2+
3+
* fix/ Use globalThis property, a standard way of accessing the global this on browser & Node ([45bdbfa](https://github.com/maximegris/angular-electron/commit/45bdbfa))
4+
* misc/ disable 'jsdoc/newline-after-description' rule ([9b22567](https://github.com/maximegris/angular-electron/commit/9b22567))
5+
* misc/ Enable Typescript strict mode ([f60add8](https://github.com/maximegris/angular-electron/commit/f60add8))
6+
* misc/ Update angular material HOW TO guide ([18c5431](https://github.com/maximegris/angular-electron/commit/18c5431))
7+
* misc/ Upgrade electron-builder dependency ([04a3b14](https://github.com/maximegris/angular-electron/commit/04a3b14))
8+
* misc/ Upgrade to Angular 15.2.9 & Electron 24 ([7c78613](https://github.com/maximegris/angular-electron/commit/7c78613))
9+
* misc/ Upgrade to Angular 16.1.3 & Electron 2 ([5f8e817](https://github.com/maximegris/angular-electron/commit/5f8e817))
10+
11+
12+
13+
## 12.0.0 (2023-02-17)
14+
15+
* [Bumped Version] 12.0.0 ([f78a81f](https://github.com/maximegris/angular-electron/commit/f78a81f))
16+
* misc/ Upgrade to Electron 22 ([8cb0acd](https://github.com/maximegris/angular-electron/commit/8cb0acd))
17+
* package json description updated ([8726c0a](https://github.com/maximegris/angular-electron/commit/8726c0a))
18+
* fix(test): remove require.context (not needed) ([680d18d](https://github.com/maximegris/angular-electron/commit/680d18d))
19+
* refactor: use latest eslint ([41abef1](https://github.com/maximegris/angular-electron/commit/41abef1))
20+
* refactor: use latest eslint & change docs ([9f8add6](https://github.com/maximegris/angular-electron/commit/9f8add6))
21+
* feat: use latest angular / angular-builder / angular-eslint ([fd9f876](https://github.com/maximegris/angular-electron/commit/fd9f876))
22+
23+
24+
125
## 11.2.0 (2022-10-16)
226

27+
* [Bumped Version] 11.2.0 ([0fd7a31](https://github.com/maximegris/angular-electron/commit/0fd7a31))
328
* misc/ Upgrade to Electron 21 ([ed23e89](https://github.com/maximegris/angular-electron/commit/ed23e89))
429

530

HOW_TO.md

+10-10
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ ng add ngx-bootstrap
1414

1515
### How to install Angular Material
1616

17+
Replace temporarily custom builders by default ones in `angular.json`
18+
19+
@angular-builders/custom-webpack:browser => @angular-devkit/build-angular:browser \
20+
@angular-builders/custom-webpack:dev-server => @angular-devkit/build-angular:dev-server
21+
1722
Add Angular Material using `ng add` command:
1823

1924
``` bash
@@ -24,16 +29,11 @@ You will get the following questions:
2429
``` bash
2530
? Choose a prebuilt theme name, or "custom" for a custom theme: *Choose any theme you like here*
2631
? Set up global Angular Material typography styles? *Yes*
27-
? Set up browser animations for Angular Material? *Yes*
32+
? Set up browser animations for Angular Material? *Do not include / error if you choose Include*
2833
```
29-
Angular Material will start installing, but you will get the following error after installation:
34+
Angular Material Library is now installed in your project.
3035
31-
``` bash
32-
Your project is not using the default builders for "build". The Angular Material schematics cannot add a theme to the workspace configuration if the builder has been changed.
33-
```
34-
*No need to Panic!* Just add your desired theme in style.scss:
36+
Put back custom builders in `angular.json`
3537
36-
``` bash
37-
@import '@angular/material/prebuilt-themes/indigo-pink.css'
38-
```
39-
Angular Material Library is now installed in your project.
38+
@angular-devkit/build-angular:browser => @angular-builders/custom-webpack:browser \
39+
@angular-devkit/build-angular:dev-server => @angular-builders/custom-webpack:dev-server

README.md

+12-6
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414

1515
# Introduction
1616

17-
Bootstrap and package your project with Angular 14 and Electron 21 (Typescript + SASS + Hot Reload) for creating Desktop applications.
17+
Bootstrap and package your project with Angular 16 and Electron 25 (Typescript + SASS + Hot Reload) for creating Desktop applications.
1818

1919
Currently runs with:
2020

21-
- Angular v14.2.6
22-
- Electron v21.1.1
21+
- Angular v16.1.3
22+
- Electron v25.2.0
2323

2424
With this sample, you can:
2525

@@ -29,7 +29,7 @@ With this sample, you can:
2929

3030
/!\ Hot reload only pertains to the renderer process. The main electron process is not able to be hot reloaded, only restarted.
3131

32-
/!\ Angular CLI & Electron Builder needs Node 14 or later to work correctly.
32+
/!\ Angular CLI & Electron Builder needs Node 18.10 or later to work correctly.
3333

3434
## Getting Started
3535

@@ -140,6 +140,10 @@ Finally from VsCode press **Ctrl+Shift+D** and select **Application Debug** and
140140

141141
Please note that Hot reload is only available in Renderer process.
142142

143+
## Want to use Angular Material ? Ngx-Bootstrap ?
144+
145+
Please refer to [HOW_TO file](./HOW_TO.md)
146+
143147
## Branch & Packages version
144148

145149
- Angular 4 & Electron 1 : Branch [angular4](https://github.com/maximegris/angular-electron/tree/angular4)
@@ -152,8 +156,10 @@ Please note that Hot reload is only available in Renderer process.
152156
- Angular 11 & Electron 12 : Branch [angular11](https://github.com/maximegris/angular-electron/tree/angular11)
153157
- Angular 12 & Electron 16 : Branch [angular12](https://github.com/maximegris/angular-electron/tree/angular12)
154158
- Angular 13 & Electron 18 : Branch [angular13](https://github.com/maximegris/angular-electron/tree/angular13)
155-
- Angular 14 & Electron 21 : (main)
156-
159+
- Angular 14 & Electron 21 : Branch [angular14](https://github.com/maximegris/angular-electron/tree/angular14)
160+
- Angular 15 & Electron 24 : Branch [angular15](https://github.com/maximegris/angular-electron/tree/angular15)
161+
- Angular 16 & Electron 25 : (main)
162+
-
157163
[maintained-badge]: https://img.shields.io/badge/maintained-yes-brightgreen
158164
[license-badge]: https://img.shields.io/badge/license-MIT-blue.svg
159165
[license]: https://github.com/maximegris/angular-electron/blob/main/LICENSE.md

0 commit comments

Comments
 (0)