Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2.0 changes #855

Closed
wants to merge 4 commits into from
Closed

Feature/2.0 changes #855

wants to merge 4 commits into from

Conversation

WSSDude
Copy link
Collaborator

@WSSDude WSSDude commented Sep 25, 2023

No description provided.

@WSSDude
Copy link
Collaborator Author

WSSDude commented Sep 25, 2023

  • crashes when launched from Steam (which launches some launcher, hitting play there causes crash...)
  • crashes on exit (when launched directly from EXE)

@grzeli
Copy link

grzeli commented Sep 26, 2023

@WSSDude game started from .exe file crashes, even when there are no mods.

@WSSDude
Copy link
Collaborator Author

WSSDude commented Sep 26, 2023

I know, found out shortly after I posted the comment about launcher crashing.
Debugger has to be attached for some reason for it to not crash.

@Lukas0610
Copy link
Contributor

Lukas0610 commented Sep 26, 2023

I know, found out shortly after I posted the comment about launcher crashing. Debugger has to be attached for some reason for it to not crash.

That's probably because there's small code-snippet in src/dllmain.cpp:23 which forces the game to wait for a debugger to be attached:

while (!IsDebuggerPresent())
    Sleep(1000);

That code-snippet is always executed as soon as CET is loaded by an application via the ASI-loader, so take a look at the launcher-executable using something like System Informer if it indeed loaded CET

Edit: Maybe a few checks should be added that CET is indeed running in the actual Cyberpunk-Executable

@WSSDude WSSDude closed this Sep 27, 2023
@WSSDude WSSDude deleted the feature/2.0_changes branch October 4, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants