Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate run argument to actions #338

Open
maxheld83 opened this issue Aug 20, 2019 · 2 comments
Open

deprecate run argument to actions #338

maxheld83 opened this issue Aug 20, 2019 · 2 comments
Labels
blocked github Related to / requiring support from github (actions)

Comments

@maxheld83
Copy link
Owner

it appears that the runs arguments to actions (which used to just be appended to docker run as COMMAND and ARGS), has been deprecated.

Now you can only overwrite entrypoint and args separately.

Like so:

- name: Download Cache
        uses: actions/gcloud/cli@d124d4b82701480dc29e68bb73a87cfb2ce0b469
        with:
          entrypoint: gsutil
          args: -m cp -r gs://ghactions-cache/lib.tar.gz /github/home/

Whereas before, we could:

action "Download Cache" {
  uses = "actions/gcloud/cli@d124d4b82701480dc29e68bb73a87cfb2ce0b469"
  runs = "gsutil -m cp -r gs://ghactions-cache/lib.tar.gz /github/home/"
}

Not a huge limitation, but something to be aware of.
Just slightly less convenient, I guess.

@maxheld83
Copy link
Owner Author

also need to verify this with support.

@maxheld83 maxheld83 added the github Related to / requiring support from github (actions) label Aug 20, 2019
@maxheld83
Copy link
Owner Author

wrote to support to verify:

on the old, HCL-based github actions there was a runs parameter, which would just be prepended to docker run ... as COMMAND and ARGS, effectively overwriting any default entrypoint and args.

It appears that this is now no longer supported via steps.with.*, but you only have entrypoint and args, which can achieve the same result.

More details here: #338

Do I have this right?

If so, it might be worthwhile a) to add it back in, or b) to note in the docs that runs has been deprecated, because it's something the old actions could do.
Probably makes more sense to deprecate, since it was always a bit confusing/redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked github Related to / requiring support from github (actions)
Projects
None yet
Development

No branches or pull requests

1 participant