Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

are actions still cached #315

Open
maxheld83 opened this issue Aug 13, 2019 · 3 comments
Open

are actions still cached #315

maxheld83 opened this issue Aug 13, 2019 · 3 comments
Labels
blocked github Related to / requiring support from github (actions)

Comments

@maxheld83
Copy link
Owner

maybe there's enough caching out of the box in the new gh actions

@maxheld83 maxheld83 changed the title check whether publishing docker images is still necessary are actions still cached Aug 20, 2019
@maxheld83
Copy link
Owner Author

it appears as per the above commit that action images are no longer cached.
Calling them with a tag from docker "manually" will probably still get the tag, but there's no magical translation happening from GitHub repos, as there used to be.

If that is so then it's probably also unnecessary to publish images to docker hub in the first place, unless we're going the manual route.

Have to double check this, then ask support.

maxheld83 added a commit that referenced this issue Aug 20, 2019
maxheld83 added a commit that referenced this issue Aug 20, 2019
maxheld83 added a commit that referenced this issue Aug 20, 2019
maxheld83 added a commit that referenced this issue Aug 20, 2019
@maxheld83
Copy link
Owner Author

above commits confirm that images are no longer pulled from docker hub, unless docker:// is explicitly given.

@maxheld83
Copy link
Owner Author

AFAIK, the old, HCL-based GitHub actions would pull, not build, images for GitHub actions from Docker Hub when action images would be pushed and tagged properly (via the actions action).

For example,

action "GCP Authenticate" {
uses = "actions/gcloud/auth@d124d4b82701480dc29e68bb73a87cfb2ce0b469"
secrets = [
"GCLOUD_AUTH"
]
}

would just pull docker://github/gcloud-auth:d124d4b82701480dc29e68bb73a87cfb2ce0b469.

For actions with bigger docker images, this could save a considerable amount of time.

This feature appears to be gone now.

Unless I specifically uses: docker:// the image always gets docker build first, which can take a long time.

This makes things easier, and the old magical way of tagging docker images with git shas and refs was always a bit weird.

I just want to know whether this feature:
is coming back
is coming back in another form (i.e. by using another registry under the hood or whatever)
is not coming back, and I have to runs:: docker://... if I want to avoid docker build.
Knowing this would be immensely helpful in building out our actions.

Also, perhaps other people might stumble over this and it might be worth pointing out this change in the docs?

@maxheld83 maxheld83 added blocked github Related to / requiring support from github (actions) labels Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked github Related to / requiring support from github (actions)
Projects
None yet
Development

No branches or pull requests

1 participant