You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
maxheld83 opened this issue
May 1, 2019
· 4 comments
Labels
byodbring your own dockerfile; design where every project gets a custom docker BUILDdockeranything docker relatedgithubRelated to / requiring support from github (actions)pkg-devstuff to help other package developers
currently, we've always specified R-dependencies (packages) by hand in the byod-Dockerfile.
It's arguably good to get rid of DESCRIPTIONs for Rmd projects, where it was always a little awkward and necessary only because of Travis.
But for pkg dev, we must install the dependencies from DESCRIPTION (not Dockerfile).
For some packages, installing all the dependencies can be pretty expensive, so the question is how to make this fast.
Right now, I see two options to do this:
Every package uses the same docker image as per provide good docker image for pkg devel #106.
We then invoke remotes:: before, say, the build action, to get all the necessary dependencies.
This takes a while, so we need caching (travis had this out-of-the-box).
We can either:
In the meantime, cache somewhere else (probably a bad idea because of network ingress issues etc.).
We actually build a new docker image for every package, and bake the current dependencies into it, by running remotes::inside the Dockerfile.
This then again requires the somewhat awkward first step of building a custom docker image for every pkg repo, from which follows an even more awkward way to load these images downstream see find a more elegant way to identify docker images from past docker build . actions #1 (haha! this is an old one!).
The upside is that I think this gives us caching out of the box, b/c GitHub seems to natively cache docker build actions already. (Need to double check this as per cache byod images #3) (another early issue!)
The text was updated successfully, but these errors were encountered:
byodbring your own dockerfile; design where every project gets a custom docker BUILDdockeranything docker relatedgithubRelated to / requiring support from github (actions)pkg-devstuff to help other package developers
currently, we've always specified R-dependencies (packages) by hand in the byod-
Dockerfile
.It's arguably good to get rid of
DESCRIPTION
s for Rmd projects, where it was always a little awkward and necessary only because of Travis.But for pkg dev, we must install the dependencies from
DESCRIPTION
(notDockerfile
).For some packages, installing all the dependencies can be pretty expensive, so the question is how to make this fast.
Right now, I see two options to do this:
We then invoke
remotes::
before, say, the build action, to get all the necessary dependencies.This takes a while, so we need caching (travis had this out-of-the-box).
We can either:
remotes::
inside theDockerfile
.This then again requires the somewhat awkward first step of building a custom docker image for every pkg repo, from which follows an even more awkward way to load these images downstream see find a more elegant way to identify docker images from past
docker build .
actions #1 (haha! this is an old one!).The upside is that I think this gives us caching out of the box, b/c GitHub seems to natively cache
docker build
actions already. (Need to double check this as per cache byod images #3) (another early issue!)The text was updated successfully, but these errors were encountered: