Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ProofOptions as command arguments #14

Merged
merged 3 commits into from
Jul 5, 2022
Merged

feat: add ProofOptions as command arguments #14

merged 3 commits into from
Jul 5, 2022

Conversation

tdelabro
Copy link
Contributor

close #12

Arguments are parsed and refused according to those specifications:
https://docs.rs/winterfell/latest/winterfell/struct.ProofOptions.html#panics

@maxgillett
Copy link
Owner

maxgillett commented Jun 28, 2022 •
edited
Loading

Thanks! Can we replace all references to with_96_bit_security with with_proof_options?

@tdelabro
Copy link
Contributor Author

tdelabro commented Jun 30, 2022 •
edited
Loading

Can we replace all references to with_96_bit_security with with_proof_options?

Done.
Also, the test was not compiling. I fixed it. But one is falling

@maxgillett maxgillett merged commit 934d4f4 into maxgillett:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panicked on read_builtins when output builtin used
2 participants
@tdelabro @maxgillett