ERROR: Puppet 4.0 no longer supports local scope defined types

[mlehner616]

This module breaks in Puppet 4.0 as it no longer supports locally scoped defined types as in manifests/vcl.pp. I'd like to get this into a pull request ASAP but before I do I'd like to make sure someone will be available to merge it in and provide some feedback before going through the trouble. I'm not sure if this module is actively being maintained.

I received this error after updating to Puppet 4.0:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: 
Evaluation Error: Error while evaluating a Resource Statement, 
Invalid resource type includefile at 
/etc/puppetlabs/code/environments/dev/modules/varnish/manifests/vcl.pp:100:5 
on node varnish.local

I have patched this locally using following suggested fix.

in manifests/vcl.pp:
Move the following into manifests/includefile.pp and rename the define to varnish::includefile

  # define include file type
  define includefile {
    $selectors = $varnish::vcl::selectors
    concat { "${varnish::vcl::includedir}/${title}.vcl":
      owner   => 'root',
      group   => 'root',
      mode    => '0444',
      notify  => Service['varnish'],
      require => File[$varnish::vcl::includedir],
    }

    concat::fragment { "${title}-header":
       target  => "${varnish::vcl::includedir}/${title}.vcl",
      content => "# File managed by Puppet\n",
      order   => '01',
    }
  }

On manifests/vcl.pp line 100:
change includefile { $includefiles: }
to varnish::includefile { $includefiles: }

[maxchk]

Thanks for reporting this.
Please make a pull request and I'll merge it in.

[jeremycrussell]

This is currently fixed is the "develop" branch using varnish::vcl::includefile along with quite a few other changes to that class.

[EmersonPrado]

Problem persists in defined type manifests/acl.pp and class manifests/vcl.pp, each one with a nested defined type.

[EmersonPrado]

Added PR 160