From c3cb776c82a0a8f1b9554e28969983ca385f3241 Mon Sep 17 00:00:00 2001 From: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com> Date: Mon, 28 Aug 2023 15:53:18 -0500 Subject: [PATCH] [ADAP-849] removes some user connection details from stdout (#756) * update RELEASE_BRANCH env * remove some connection fields that may be sensitive user information that we don't want showing up in dbt debug commands * add changelog and comment pointing to docs --- .changes/unreleased/Fixes-20230828-143834.yaml | 6 ++++++ dbt/adapters/snowflake/connections.py | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changes/unreleased/Fixes-20230828-143834.yaml diff --git a/.changes/unreleased/Fixes-20230828-143834.yaml b/.changes/unreleased/Fixes-20230828-143834.yaml new file mode 100644 index 000000000..793b2b65c --- /dev/null +++ b/.changes/unreleased/Fixes-20230828-143834.yaml @@ -0,0 +1,6 @@ +kind: Fixes +body: remove senesitive creds from dbt debug stdout +time: 2023-08-28T14:38:34.380646-05:00 +custom: + Author: McKnight-42 + Issue: "754" diff --git a/dbt/adapters/snowflake/connections.py b/dbt/adapters/snowflake/connections.py index 3272eee55..be3477b69 100644 --- a/dbt/adapters/snowflake/connections.py +++ b/dbt/adapters/snowflake/connections.py @@ -103,6 +103,8 @@ def type(self): def unique_field(self): return self.account + # the results show up in the output of dbt debug runs, for more see.. + # https://docs.getdbt.com/guides/dbt-ecosystem/adapter-development/3-building-a-new-adapter#editing-the-connection-manager def _connection_keys(self): return ( "account", @@ -112,9 +114,7 @@ def _connection_keys(self): "role", "schema", "authenticator", - "private_key", "private_key_path", - "private_key_passphrase", "token", "oauth_client_id", "query_tag",