Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the module structure #3

Open
max-ishere opened this issue Feb 16, 2024 · 0 comments
Open

Reorganize the module structure #3

max-ishere opened this issue Feb 16, 2024 · 0 comments
Assignees

Comments

@max-ishere
Copy link
Owner

Currently there are 2 modules: parser and render. Each contains submodules for theme.txt and the pff2 font. However it seems like this structure doesnt work all that well and would have to be reorganized.

The best time to do this is after everything is parsable into Rusty structs. Then the rusty structs go into the module that will be exposed to the users, which can then be borrowed by the module that does the rendering (just PNG making really) or if the user of the lib wants to parse some files (e.g. to display it in a nice way in an editor) they can do that too.

The main issue is that these modules at the moment dont do what they say they do. parser does parse the files, but render takes parser structs and turns them into something validated. The only exception is perhaps some implementations for Glyph rendering

@max-ishere max-ishere self-assigned this Feb 16, 2024
@max-ishere max-ishere changed the title Reorganize the folder structure Reorganize the module structure Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant