Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Remote Id refactor #12018

Open
DonLakeFlyer opened this issue Oct 16, 2024 · 2 comments
Open

Finish Remote Id refactor #12018

DonLakeFlyer opened this issue Oct 16, 2024 · 2 comments
Assignees

Comments

@DonLakeFlyer
Copy link
Contributor

DonLakeFlyer commented Oct 16, 2024

Current toolbar indicator:
Screenshot 2024-10-29 at 1 02 16 PM

Current App Settings page:
Screenshot 2024-10-29 at 1 02 47 PM

Changes:

  • The full settings UI which is currently available from the toolbar indicator should move to App Settings and replace the old style settings UI which is currently there:
    • I would keep the two-column format to reduce the need for vertical scrolling
    • Support for NMEA device selection needs to be added to the new ui. It was left out by accident in the initial work.
    • I would lay out the status indicators horizontally like they are laid out in the old style ui
  • The expanded remote id toolbar indicator page should only show:
    • The Arm status error stuff
    • The Self ID settings:
    • The reasoning behind this is the toolbar indicator ui expanded page is used for things which may need to change from one flight to the next. It should not include things which are one time vehicle setup things.
  • The initial discussion around this can be found in Rework Remote ID settings to new style #11993
@BluemarkInnovations
Copy link

See also this comment #11993 (comment)

@DonLakeFlyer
Copy link
Contributor Author

Let's do the simple UI movement first in one pull and then we can discuss/fix the things @BluemarkInnovations brought up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants