Integration tests fail on Windows

[ctrueden]

Ever since the merge of #170, the integration tests fail on Windows. This needs to be resolved to avoid Windows-specific regressions in the code in the future.

[Oneplus]

all integration tests passed on my own laptop which has only one msvc installation. But my CI failed on a system that has multiple msvc installations. https://ci.appveyor.com/project/Oneplus/ltp4j/build/14. and I think the problem points to #217 . Could this be the same reason for integration tests failures?

[ctrueden]

Thanks for the additional information, @Oneplus. For what it's worth, the job configuration to which I refer is here. Ultimately, it would be good to migrate that CI build off of that server and onto a more community-facing one such as Appveyor and/or Travis CI.

Unfortunately, I don't have any time to pursue that, nor to diagnose/fix the IT failures on (some) Windows systems. But if anyone else wants to take the lead on it, I will do everything I can to help.

[Oneplus]

Hi @ctrueden If you are considering put the CI to Appveyor and Travis CI, it's pretty easy. All you need to do is to add the project to the CI service and add CI configuration file to the project.

I've added my own fork of nar-maven-plugin to the Appveyor and Travis CI and here is the IT result.

• https://ci.appveyor.com/project/Oneplus/nar-maven-plugin
• https://travis-ci.org/Oneplus/nar-maven-plugin/jobs/122403758

the windows and linux IT pass. However, the OSX IT fails and it says

[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 22, Failed: 2, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[ERROR] The following builds failed:
[ERROR] *  it0026-native-lib-loader/pom.xml
[ERROR] *  it0028-scope/pom.xml

Unfortunately, I am not an Apple users and cannot work on this issues.

Anyway, If you want to use Appveyor and Travis CI, you would like to merge my PR #220 and add the project in the CI services (it requires the maintainer of the project).

[Oneplus]

One more thing to note is that PR #220 also contains a fix for the MSVC compiler version comparison problem as #217 .

[karypid]

Hi,

It looks like something is already broken for windows: https://groups.google.com/d/msg/maven-nar/Orm_I0tL4pE/LdkS_sb0AQAJ

I assume these integration tests are still not working?

Update: I just cloned/checked-out the repo and ran "mvn integration-test". It succeeded, but I don't think it really did anything. I only have GNU compilers on this Windows box. How are these tests run?

[ctrueden]

Since the above discussion, my group's Windows Jenkins node went down, and is still in the process of being restored. Even after we restore it, though, it would really be much better to do NAR's CI using OSS community resources (e.g., Travis + Appveyor) rather than using my group's server. If you have the time and energy to configure that, then by all means, go for it. I would love to have integration tests for Windows, macOS and Linux platforms which all pass on the master branch. It becomes complicated for this project, though, because there are lots of different ways to have things configured—e.g., minGW vs. MSVS at various versions on Windows, or all the various macOS releases with gcc vs. clang. But testing some standard configuration(s) would certainly be better than testing nothing.

I know that some integration tests also fail on various flavors of macOS, for example, but no one has time and energy to invest in fully understanding and fixing those.

[ctrueden]

@karypid

How are these tests run?

Sorry I missed this before. The answer is mvn -Prun-its. See also the Testing page.

@Oneplus If you are still around: would you be willing to file a PR adding the Appveyor configuration? At this point, my group has decided not to resurrect the Windows node of our CI, so Appveyor is definitely going to be the way forward to test NAR on Windows.

[Oneplus]

Hi @ctrueden, I think the appveyor configure file is ready. You may need to log into their website and add the nar-maven-plugin project and hopefully, it will do everything automatically.

[ctrueden]

I think the appveyor configure file is ready.

Oh right, we already merged it ~1 year ago. Sorry for the noise.

And now I remember what the hold-up was last time I looked at this: the URL annoyingly has my username ctrueden in it, instead of maven-nar as desired. I guess I need to register a new account for the maven-nar organization? All I want is for the URL to be https://ci.appveyor.com/project/maven-nar/nar-maven-plugin ... !

A colleague of mine (@stelfrich) was able to use the org name in the URL of a project of ours (https://ci.appveyor.com/project/imagej/imagej-launcher) so I @ mention him here in case he wants to describe how he did that!

[stelfrich]

I had changed my personal username to the name of the organization (i.e. imagej): not a real solution to the problem.

Most likely, you will have to register a new account, @ctrueden. I couldn't find a better solution..

[ctrueden]

OK. Thanks @stelfrich for the info! I had to thumbs-down your comment because ZOMG! 😜

I have filed a separate issue #275 to deal with this (creating a maven-nar organization account on Appveyor), since I don't have time now.