Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Wordpress Gutenberg Blocks for All Shortcodes #119

Open
weismannweb opened this issue Nov 25, 2021 · 3 comments
Open

Create Wordpress Gutenberg Blocks for All Shortcodes #119

weismannweb opened this issue Nov 25, 2021 · 3 comments

Comments

@weismannweb
Copy link

weismannweb commented Nov 25, 2021

Any interest in this?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@weismannweb weismannweb changed the title Create Wordpress Gutenberg Block for All Shortcodes Create Wordpress Gutenberg Blocks for All Shortcodes Nov 25, 2021
@weismannweb
Copy link
Author

weismannweb commented Nov 25, 2021

@shulard
Copy link
Collaborator

shulard commented Nov 25, 2021

Hello !

Aren't the shortcodes still supported ? Introducing Gutenberg blocks will imply adding some JS things and this plugin will be more complex to maintain… I'm not sure it's relevant to make that conversion now. Maybe you can ask on Mautic support forum if it's an interesting thing to be done for our current users.

@weismannweb
Copy link
Author

weismannweb commented Nov 25, 2021

yes they are still supported but blocks is the path forward and i imagine at some point it will be needed, also shortcodes are sometimes not supported in other shortcodes or some blocks i think unless you use a hook and do_shortcode on that content via a filter, blocks are much more user friendly too, but your right this would be harder to maintain, maybe you can make me the appropriate hooks (unless wp hooks can do it), or do the right refactoring so i can call the right functions, so that i can turn your code into blocks with a seperate companion plugin? i am also interested in doing the counter from #114 which i can commit a shortcode for here, and have a block in my plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants