Using the library by adding it to tsconfig instead of .d.ts file

[dvirberlo]

Hi @mattpocock,
(I figured Youtube comments isn't the place to have a long disccustions about this.)

I accualy tried to add the @total-typescript/ts-reset library to the tsconfig like so(on existing vite- solidJS project):
(https://www.typescriptlang.org/tsconfig#types)

{
  "compilerOptions": {
    "strict": true,
    "target": "ESNext",
    "module": "ESNext",
    "moduleResolution": "node",
    "allowSyntheticDefaultImports": true,
    "esModuleInterop": true,
    "jsx": "preserve",
    "jsxImportSource": "solid-js",
    "types": ["vite/client", "@total-typescript/ts-reset"],
    "noEmit": true,
    "isolatedModules": true,
    "resolveJsonModule": true
  }
}

And everything seem to be fine ( I activated "typescript.inlayHints.variableTypes.enabled": true for demostration ):

Code

(async () => {
  // I used tsconfig.json -> 'compilerOptions' -> 'types' -> ['vite/types', '@total-typescript/reset']
  // everything from '@total-typescript/reset' looks working to me:

  const netJson = await (
    await fetch('https://jsonplaceholder.typicode.com/todos/1')
  ).json();
  const strJson = JSON.parse("{hello: 'world'}");

  const arr = [1, 2, undefined, 'hello', true, false, [], {}];
  type NumOrTrue = number | true;
  function filter(i: (typeof arr)[number]): i is NumOrTrue {
    return typeof i === 'number' || i === true;
  }
  const filtered = arr.filter(filter);

  const includes = [1, 2, 3, 4].includes(3);
  const includesConst = ([1, 2, 3, 4] as const).includes(3);

  // and still use 'vite/types'
  const viteHot = import.meta.hot;
})();

I did not see any issues using it like that, and it did not even override the Vite types.
If this works, it can also be used in libraries, I think.

Did I miss something?