Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Developer documentation #401

Open
yarbelk opened this issue May 24, 2019 · 3 comments
Open

New Developer documentation #401

yarbelk opened this issue May 24, 2019 · 3 comments

Comments

@yarbelk
Copy link

yarbelk commented May 24, 2019

I would like it if you could give some good advice to people who wish to contribute. There is deep magic in the gobject and GTK libraries that is not clear to me (and probably many golang developers). The team has obviously figured out how to deal with it; but lets say I want to help drive the % up, and possibly add libhandy bindings: what do I need to know?
What are the pitfalls I'm going to screw up? how do I coherently test this code?

This could be a wall of prose, or even as a beginning, point form with links to cannonical examples in what you've already done. There is enough code here that I cannot easilly find the 'good' example to copy.

and i really, really, want to help

@mattn
Copy link
Owner

mattn commented May 24, 2019

At the first, I must understand what is current issue.

  • No documentations?
  • More better examples?
  • Un-clearly APIs?

@yarbelk
Copy link
Author

yarbelk commented May 28, 2019

As a non-C developer, I would like a canonical example of F(gtk_func_in_C) -> 'gtk_func_in_go'
that is well documented, and explains how they differ. In this way, I can make PRs to this repo to add in missing functionality. I don't really know what I don't know when it comes to how badly I can screw up the memory model, and a little bit of pointing in the right direction in terms of convention and testing would go long way.

The Go APIs are clear enough(I think as I struggle with any GUI, be it css/html, or gtk, or qt) because I think in pipes and data streams).

@yarbelk
Copy link
Author

yarbelk commented Jul 1, 2019

In another way:
What is the best piece of code in this repository graded on: Clarity, demonstrating conventions and documentation.

For comparison: when I'm giving an example from the standard library of golang, I usually link to https://github.com/golang/go/blob/master/src/sort/sort.go which demonstrates one non-java like usage of an interface, the different between exported and not and how they interact, and how to comment code. (and expert level use of the underlying primitives in golang)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants