Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin a specific commit of a plugin #1

Open
mattmc3 opened this issue Mar 7, 2022 · 3 comments
Open

Pin a specific commit of a plugin #1

mattmc3 opened this issue Mar 7, 2022 · 3 comments
Labels
enhancement New feature or request vNext Planned for the next release

Comments

@mattmc3
Copy link
Owner

mattmc3 commented Mar 7, 2022

Per getantibody/antibody#386:

Is it possible to pin a specific commit of a plugin in case of breaking changes?

@obvionaoe
Copy link

Are there any blockers to this feature being implemented? I'd like to help, if possible

@mattmc3
Copy link
Owner Author

mattmc3 commented May 30, 2024

No blockers - I've always thought of it as a pretty easy feature. I haven't done it yet because there hasn't been a lot of interest in it before now, and I just need some volunteers to test it.

My take on implementing the feature is this:

  • Add a pin:SHA annotation that tells antidote which commit SHA you want for your plugins.
  • Add a pin subcommand like: antidote pin [-r|--remove] [<PLUGIN>] [<SHA>]. This lets you pin (or unpin) a plugin (or all plugins) to either a specified SHA or whatever is current
  • Ensure antidote update respects pinning and is a no-op for pinned repos
  • Perhaps allow antidote update to unpin and then re-pin for a updates (a --force flag??)
  • Figure out error handling of invalid SHAs
  • Update all the docs

Any other relevant features you'd like me to consider as part of this feature?

@obvionaoe
Copy link

Adding a layer that could convert tags to commit SHAs, as I have a few plugins that I version using tags. I'd make it so that the pin annotation would support pin:SHA|TAG

@mattmc3 mattmc3 added the vNext Planned for the next release label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vNext Planned for the next release
Projects
None yet
Development

No branches or pull requests

2 participants