Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching of call results is currently disabled #1

Open
mattja opened this issue Jun 22, 2016 · 1 comment
Open

caching of call results is currently disabled #1

mattja opened this issue Jun 22, 2016 · 1 comment
Labels

Comments

@mattja
Copy link
Owner

mattja commented Jun 22, 2016

Currently caching relies on the id() of the proxy object as part of the key for storing cached results.
This is wrong, as the id is only guaranteed to be unique among objects existing at the same time.

Result: If a proxy object is deleted and later another proxy with the same interface happens to be created at the same address in memory (not unlikely) then the new proxy may return cached results that belong to the old proxy.

Solution: Instead of a global cache, have one cache instance per proxy, with only the total memory usage managed globally

@mattja
Copy link
Owner Author

mattja commented Jun 23, 2016

Disabling method result caching globally until I have time to do this properly.

@mattja mattja changed the title cached call results may be wrong caching of call results is currently disabled Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant