Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRID datastructure refacto #8

Open
matthieugayon opened this issue Sep 28, 2021 · 0 comments
Open

GRID datastructure refacto #8

matthieugayon opened this issue Sep 28, 2021 · 0 comments

Comments

@matthieugayon
Copy link
Owner

the Pattern datastructure is for the moment mapped in a straightforward fashion from the GridPattern struct, because their length is Equal ( NUM_STEPS = 32)

In the future this number may differ, so we need to rewrite the mapping, to adapt to any kind of difference

impl From<GridPattern> for Pattern {

and we need to introduce two new concepts to the grid : editable time signature & granularity (Widest , Wide, Medium, Narrow, Narrowest).

This has several consequences :

  • displayed offsets are no longer the one contained in the Pattern datastructure, it's a grid artefact and it needs to be mapped to the granularity
  • new move rules
  • possibly gate length introduction
  • ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant