Skip to content

Commit 21bb9ab

Browse files
matthiaskrgrflip1995
authored andcommitted
1 parent c66cca4 commit 21bb9ab

File tree

154 files changed

+306
-151
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

154 files changed

+306
-151
lines changed

clippy_lints/src/approx_const.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
use crate::utils::span_lint;
2+
use rustc::declare_lint_pass;
23
use rustc::hir::*;
34
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4-
use rustc::{declare_lint_pass, declare_tool_lint};
5+
use rustc_session::declare_tool_lint;
56
use std::f64::consts as f64;
67
use syntax::ast::{FloatTy, LitFloatType, LitKind};
78
use syntax::symbol;

clippy_lints/src/arithmetic.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
use crate::consts::constant_simple;
22
use crate::utils::span_lint;
33
use rustc::hir;
4+
use rustc::impl_lint_pass;
45
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
5-
use rustc::{declare_tool_lint, impl_lint_pass};
6+
use rustc_session::declare_tool_lint;
67
use syntax::source_map::Span;
78

89
declare_clippy_lint! {

clippy_lints/src/as_conversions.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
use rustc::declare_lint_pass;
12
use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass};
2-
use rustc::{declare_lint_pass, declare_tool_lint};
3+
use rustc_session::declare_tool_lint;
34
use syntax::ast::*;
45

56
use crate::utils::span_help_and_lint;

clippy_lints/src/assertions_on_constants.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ use crate::consts::{constant, Constant};
22
use crate::utils::paths;
33
use crate::utils::{is_direct_expn_of, is_expn_of, match_function_call, snippet_opt, span_help_and_lint};
44
use if_chain::if_chain;
5+
use rustc::declare_lint_pass;
56
use rustc::hir::*;
67
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
7-
use rustc::{declare_lint_pass, declare_tool_lint};
8+
use rustc_session::declare_tool_lint;
89
use syntax::ast::LitKind;
910

1011
declare_clippy_lint! {

clippy_lints/src/assign_ops.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
use if_chain::if_chain;
2+
use rustc::declare_lint_pass;
23
use rustc::hir;
34
use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
45
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
5-
use rustc::{declare_lint_pass, declare_tool_lint};
66
use rustc_errors::Applicability;
7+
use rustc_session::declare_tool_lint;
78

89
use crate::utils::{
910
get_trait_def_id, implements_trait, snippet_opt, span_lint_and_then, trait_ref_of_method, SpanlessEq,

clippy_lints/src/attrs.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@ use crate::utils::{
66
span_lint_and_then, without_block_comments,
77
};
88
use if_chain::if_chain;
9+
use rustc::declare_lint_pass;
910
use rustc::hir::*;
1011
use rustc::lint::{
1112
in_external_macro, CheckLintNameResult, EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintArray,
1213
LintContext, LintPass,
1314
};
1415
use rustc::ty;
15-
use rustc::{declare_lint_pass, declare_tool_lint};
1616
use rustc_errors::Applicability;
17+
use rustc_session::declare_tool_lint;
1718
use semver::Version;
1819
use syntax::ast::{AttrKind, AttrStyle, Attribute, Lit, LitKind, MetaItemKind, NestedMetaItem};
1920
use syntax::source_map::Span;

clippy_lints/src/bit_mask.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ use crate::utils::sugg::Sugg;
33
use crate::utils::{span_lint, span_lint_and_then};
44
use if_chain::if_chain;
55
use rustc::hir::*;
6+
use rustc::impl_lint_pass;
67
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
7-
use rustc::{declare_tool_lint, impl_lint_pass};
88
use rustc_errors::Applicability;
9+
use rustc_session::declare_tool_lint;
910
use syntax::ast::LitKind;
1011
use syntax::source_map::Span;
1112

clippy_lints/src/blacklisted_name.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
use crate::utils::span_lint;
22
use rustc::hir::*;
3+
use rustc::impl_lint_pass;
34
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4-
use rustc::{declare_tool_lint, impl_lint_pass};
55
use rustc_data_structures::fx::FxHashSet;
6+
use rustc_session::declare_tool_lint;
67

78
declare_clippy_lint! {
89
/// **What it does:** Checks for usage of blacklisted names for variables, such

clippy_lints/src/block_in_if_condition.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
use crate::utils::*;
22
use matches::matches;
3+
use rustc::declare_lint_pass;
34
use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
45
use rustc::hir::*;
56
use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintContext, LintPass};
6-
use rustc::{declare_lint_pass, declare_tool_lint};
7+
use rustc_session::declare_tool_lint;
78

89
declare_clippy_lint! {
910
/// **What it does:** Checks for `if` conditions that use blocks to contain an

clippy_lints/src/booleans.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ use crate::utils::{
33
span_lint_and_then, SpanlessEq,
44
};
55
use if_chain::if_chain;
6+
use rustc::declare_lint_pass;
67
use rustc::hir::intravisit::*;
78
use rustc::hir::*;
89
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
9-
use rustc::{declare_lint_pass, declare_tool_lint};
1010
use rustc_errors::Applicability;
11+
use rustc_session::declare_tool_lint;
1112
use syntax::ast::LitKind;
1213
use syntax::source_map::Span;
1314

clippy_lints/src/bytecount.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ use crate::utils::{
33
span_lint_and_sugg, walk_ptrs_ty,
44
};
55
use if_chain::if_chain;
6+
use rustc::declare_lint_pass;
67
use rustc::hir::*;
78
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
89
use rustc::ty;
9-
use rustc::{declare_lint_pass, declare_tool_lint};
1010
use rustc_errors::Applicability;
11+
use rustc_session::declare_tool_lint;
1112
use syntax::ast::{Name, UintTy};
1213

1314
declare_clippy_lint! {

clippy_lints/src/cargo_common_metadata.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
use std::path::PathBuf;
44

55
use crate::utils::span_lint;
6+
use rustc::declare_lint_pass;
67
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
7-
use rustc::{declare_lint_pass, declare_tool_lint};
8+
use rustc_session::declare_tool_lint;
89
use syntax::{ast::*, source_map::DUMMY_SP};
910

1011
use cargo_metadata;

clippy_lints/src/checked_conversions.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
//! lint on manually implemented checked conversions that could be transformed into `try_from`
22
33
use if_chain::if_chain;
4+
use rustc::declare_lint_pass;
45
use rustc::hir::*;
56
use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintContext, LintPass};
6-
use rustc::{declare_lint_pass, declare_tool_lint};
77
use rustc_errors::Applicability;
8+
use rustc_session::declare_tool_lint;
89
use syntax::ast::LitKind;
910

1011
use crate::utils::{snippet_with_applicability, span_lint_and_sugg, SpanlessEq};

clippy_lints/src/cognitive_complexity.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
33
use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
44
use rustc::hir::*;
5+
use rustc::impl_lint_pass;
56
use rustc::lint::{LateContext, LateLintPass, LintArray, LintContext, LintPass};
6-
use rustc::{declare_tool_lint, impl_lint_pass};
7+
use rustc_session::declare_tool_lint;
78
use syntax::ast::Attribute;
89
use syntax::source_map::Span;
910

clippy_lints/src/collapsible_if.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@
1313
//! This lint is **warn** by default
1414
1515
use if_chain::if_chain;
16+
use rustc::declare_lint_pass;
1617
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
17-
use rustc::{declare_lint_pass, declare_tool_lint};
18+
use rustc_session::declare_tool_lint;
1819
use syntax::ast;
1920

2021
use crate::utils::sugg::Sugg;

clippy_lints/src/comparison_chain.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
use crate::utils::{
22
get_trait_def_id, if_sequence, implements_trait, parent_node_is_if_expr, paths, span_help_and_lint, SpanlessEq,
33
};
4+
use rustc::declare_lint_pass;
45
use rustc::hir::*;
56
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
6-
use rustc::{declare_lint_pass, declare_tool_lint};
7+
use rustc_session::declare_tool_lint;
78

89
declare_clippy_lint! {
910
/// **What it does:** Checks comparison chains written with `if` that can be

clippy_lints/src/copies.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
use crate::utils::{get_parent_expr, higher, if_sequence, same_tys, snippet, span_lint_and_then, span_note_and_lint};
22
use crate::utils::{SpanlessEq, SpanlessHash};
3+
use rustc::declare_lint_pass;
34
use rustc::hir::*;
45
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
56
use rustc::ty::Ty;
6-
use rustc::{declare_lint_pass, declare_tool_lint};
77
use rustc_data_structures::fx::FxHashMap;
8+
use rustc_session::declare_tool_lint;
89
use std::collections::hash_map::Entry;
910
use std::hash::BuildHasherDefault;
1011
use syntax::symbol::Symbol;

clippy_lints/src/copy_iterator.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
use crate::utils::{is_copy, match_path, paths, span_note_and_lint};
2+
use rustc::declare_lint_pass;
23
use rustc::hir::{Item, ItemKind};
34
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4-
use rustc::{declare_lint_pass, declare_tool_lint};
5+
use rustc_session::declare_tool_lint;
56

67
declare_clippy_lint! {
78
/// **What it does:** Checks for types that implement `Copy` as well as

clippy_lints/src/dbg_macro.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
use crate::utils::{snippet_opt, span_help_and_lint, span_lint_and_sugg};
2+
use rustc::declare_lint_pass;
23
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
3-
use rustc::{declare_lint_pass, declare_tool_lint};
44
use rustc_errors::Applicability;
5+
use rustc_session::declare_tool_lint;
56
use syntax::ast;
67
use syntax::source_map::Span;
78
use syntax::tokenstream::TokenStream;

clippy_lints/src/default_trait_access.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
use if_chain::if_chain;
2+
use rustc::declare_lint_pass;
23
use rustc::hir::*;
34
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
45
use rustc::ty;
5-
use rustc::{declare_lint_pass, declare_tool_lint};
66
use rustc_errors::Applicability;
7+
use rustc_session::declare_tool_lint;
78

89
use crate::utils::{any_parent_is_automatically_derived, match_def_path, paths, span_lint_and_sugg};
910

clippy_lints/src/derive.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
use crate::utils::paths;
22
use crate::utils::{is_automatically_derived, is_copy, match_path, span_lint_and_then};
33
use if_chain::if_chain;
4+
use rustc::declare_lint_pass;
45
use rustc::hir::*;
56
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
67
use rustc::ty::{self, Ty};
7-
use rustc::{declare_lint_pass, declare_tool_lint};
8+
use rustc_session::declare_tool_lint;
89
use syntax::source_map::Span;
910

1011
declare_clippy_lint! {

clippy_lints/src/doc.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ use crate::utils::span_lint;
22
use itertools::Itertools;
33
use pulldown_cmark;
44
use rustc::hir;
5+
use rustc::impl_lint_pass;
56
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
6-
use rustc::{declare_tool_lint, impl_lint_pass};
77
use rustc_data_structures::fx::FxHashSet;
8+
use rustc_session::declare_tool_lint;
89
use std::ops::Range;
910
use syntax::ast::{AttrKind, Attribute};
1011
use syntax::source_map::{BytePos, Span};

clippy_lints/src/double_comparison.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
//! Lint on unnecessary double comparisons. Some examples:
22
3+
use rustc::declare_lint_pass;
34
use rustc::hir::*;
45
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
5-
use rustc::{declare_lint_pass, declare_tool_lint};
66
use rustc_errors::Applicability;
7+
use rustc_session::declare_tool_lint;
78
use syntax::source_map::Span;
89

910
use crate::utils::{snippet_with_applicability, span_lint_and_sugg, SpanlessEq};

clippy_lints/src/double_parens.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
use crate::utils::span_lint;
2+
use rustc::declare_lint_pass;
23
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
3-
use rustc::{declare_lint_pass, declare_tool_lint};
4+
use rustc_session::declare_tool_lint;
45
use syntax::ast::*;
56

67
declare_clippy_lint! {

clippy_lints/src/drop_bounds.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
use crate::utils::{match_def_path, paths, span_lint};
22
use if_chain::if_chain;
3+
use rustc::declare_lint_pass;
34
use rustc::hir::*;
45
use rustc::lint::{LateLintPass, LintArray, LintPass};
5-
use rustc::{declare_lint_pass, declare_tool_lint};
6+
use rustc_session::declare_tool_lint;
67

78
declare_clippy_lint! {
89
/// **What it does:** Checks for generics with `std::ops::Drop` as bounds.

clippy_lints/src/drop_forget_ref.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
use crate::utils::{is_copy, match_def_path, paths, qpath_res, span_note_and_lint};
22
use if_chain::if_chain;
3+
use rustc::declare_lint_pass;
34
use rustc::hir::*;
45
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
56
use rustc::ty;
6-
use rustc::{declare_lint_pass, declare_tool_lint};
7+
use rustc_session::declare_tool_lint;
78

89
declare_clippy_lint! {
910
/// **What it does:** Checks for calls to `std::mem::drop` with a reference

clippy_lints/src/duration_subsec.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
use if_chain::if_chain;
2+
use rustc::declare_lint_pass;
23
use rustc::hir::*;
34
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4-
use rustc::{declare_lint_pass, declare_tool_lint};
55
use rustc_errors::Applicability;
6+
use rustc_session::declare_tool_lint;
67
use syntax::source_map::Spanned;
78

89
use crate::consts::{constant, Constant};

clippy_lints/src/else_if_without_else.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
//! Lint on if expressions with an else if, but without a final else branch.
22
3+
use rustc::declare_lint_pass;
34
use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass};
4-
use rustc::{declare_lint_pass, declare_tool_lint};
5+
use rustc_session::declare_tool_lint;
56
use syntax::ast::*;
67

78
use crate::utils::span_help_and_lint;

clippy_lints/src/empty_enum.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
//! lint when there is an enum with no variants
22
33
use crate::utils::span_lint_and_then;
4+
use rustc::declare_lint_pass;
45
use rustc::hir::*;
56
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
6-
use rustc::{declare_lint_pass, declare_tool_lint};
7+
use rustc_session::declare_tool_lint;
78

89
declare_clippy_lint! {
910
/// **What it does:** Checks for `enum`s with no variants.

clippy_lints/src/entry.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@ use crate::utils::SpanlessEq;
22
use crate::utils::{get_item_name, higher, match_type, paths, snippet, snippet_opt};
33
use crate::utils::{snippet_with_applicability, span_lint_and_then, walk_ptrs_ty};
44
use if_chain::if_chain;
5+
use rustc::declare_lint_pass;
56
use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
67
use rustc::hir::*;
78
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
8-
use rustc::{declare_lint_pass, declare_tool_lint};
99
use rustc_errors::Applicability;
10+
use rustc_session::declare_tool_lint;
1011
use syntax::source_map::Span;
1112

1213
declare_clippy_lint! {

clippy_lints/src/enum_clike.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,14 @@
33
44
use crate::consts::{miri_to_const, Constant};
55
use crate::utils::span_lint;
6+
use rustc::declare_lint_pass;
67
use rustc::hir::*;
78
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
89
use rustc::mir::interpret::GlobalId;
910
use rustc::ty;
1011
use rustc::ty::subst::InternalSubsts;
1112
use rustc::ty::util::IntTypeExt;
12-
use rustc::{declare_lint_pass, declare_tool_lint};
13+
use rustc_session::declare_tool_lint;
1314
use std::convert::TryFrom;
1415
use syntax::ast::{IntTy, UintTy};
1516

clippy_lints/src/enum_glob_use.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
//! lint on `use`ing all variants of an enum
22
33
use crate::utils::span_lint;
4+
use rustc::declare_lint_pass;
45
use rustc::hir::def::{DefKind, Res};
56
use rustc::hir::*;
67
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
7-
use rustc::{declare_lint_pass, declare_tool_lint};
8+
use rustc_session::declare_tool_lint;
89
use syntax::source_map::Span;
910

1011
declare_clippy_lint! {

clippy_lints/src/enum_variants.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
33
use crate::utils::{camel_case, is_present_in_source};
44
use crate::utils::{span_help_and_lint, span_lint};
5+
use rustc::impl_lint_pass;
56
use rustc::lint::{EarlyContext, EarlyLintPass, Lint, LintArray, LintPass};
6-
use rustc::{declare_tool_lint, impl_lint_pass};
7+
use rustc_session::declare_tool_lint;
78
use syntax::ast::*;
89
use syntax::source_map::Span;
910
use syntax::symbol::Symbol;

0 commit comments

Comments
 (0)