Merge pull request #5 from matthewsullivan/feature/add-password-strength

Feature/add password strength

Author: matthewsullivan

app/models/user.rb

@@ -9,4 +9,5 @@ class User < ApplicationRecord
   }, presence: true, uniqueness: true
   validates :first_name, presence: true
   validates :last_name, presence: true
+  validates :password, length: { minimum: 6 }
 end

test/graph/mutations/register_test.rb

@@ -90,7 +90,15 @@ def perform(args = {})
       parameters = build_parameters(@user)
       result = perform(parameters)
 
-      assert_equal("Invalid input: Password can't be blank", result['errors'][0]['message'])
+      assert_equal("Invalid input: Password can't be blank, Password is too short (minimum is 6 characters)", result['errors'][0]['message'])
+    end
+
+    test 'should not register with short password' do
+      @user[:password] = '(a1)'
+      parameters = build_parameters(@user)
+      result = perform(parameters)
+
+      assert_equal("Invalid input: Password is too short (minimum is 6 characters)", result['errors'][0]['message'])
     end
 
     test 'should not register with duplicate email' do

test/graph/mutations/update_user_test.rb

@@ -5,6 +5,7 @@
 module Mutations
   class UpdateUserTest < ActionDispatch::IntegrationTest
     def setup
+      @password = '!a1B2c3D4e5F6g!'
       @token = login_as(users(:john))[:token]
     end
 
@@ -45,7 +46,7 @@ def perform(args = {})
             firstName: 'Jonathan',
             lastName: 'D.',
             email: '[email protected]',
-            password: '!a1B2c3D4e5F6g!'
+            password: @password
           }
         }
       }
@@ -61,7 +62,8 @@ def perform(args = {})
       parameters = {
         input: {
           arguments: {
-            firstName: ''
+            firstName: '',
+            password: @password
           }
         }
       }
@@ -74,7 +76,8 @@ def perform(args = {})
       parameters = {
         input: {
           arguments: {
-            lastName: ''
+            lastName: '',
+            password: @password
           }
         }
       }
@@ -87,7 +90,8 @@ def perform(args = {})
       parameters = {
         input: {
           arguments: {
-            email: ''
+            email: '',
+            password: @password
           }
         }
       }
@@ -100,7 +104,8 @@ def perform(args = {})
       parameters = {
         input: {
           arguments: {
-            email: '[email protected]'
+            email: '[email protected]',
+            password: @password
           }
         }
       }
@@ -113,13 +118,40 @@ def perform(args = {})
       parameters = {
         input: {
           arguments: {
-            email: 'janedoelocalhost'
+            email: 'janedoelocalhost',
+            password: @password
           }
         }
       }
       result = perform(parameters)
 
       assert_equal('Invalid input: Email invalid format', result['errors'][0]['message'])
     end
+
+    test 'should not update without password' do
+      parameters = {
+        input: {
+          arguments: {
+            password: ''
+          }
+        }
+      }
+      result = perform(parameters)
+
+      assert_equal("Invalid input: Password is too short (minimum is 6 characters)", result['errors'][0]['message'])
+    end
+
+    test 'should not update with short password' do
+      parameters = {
+        input: {
+          arguments: {
+            password: '(a1)'
+          }
+        }
+      }
+      result = perform(parameters)
+
+      assert_equal("Invalid input: Password is too short (minimum is 6 characters)", result['errors'][0]['message'])
+    end
   end
 end

test/models/user_test.rb

@@ -55,4 +55,12 @@ def setup
     refute(user.valid?)
     assert_not_nil(user.errors[:password], 'no password present')
   end
+
+  test 'should not create with short password' do
+    @user[:password] = '(a1)'
+    user = User.create(@user)
+
+    refute(user.valid?)
+    assert_equal(user.errors[:password][0], 'is too short (minimum is 6 characters)')
+  end
 end