Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc_type is gone. 2.3.7 changes many function signatures because opensearch-py did #19

Closed
matthewdeanmartin opened this issue May 28, 2024 · 1 comment
Closed

doc_type is gone. 2.3.7 changes many function signatures because opensearch-py did #19

matthewdeanmartin opened this issue May 28, 2024 · 1 comment

Comments

@matthewdeanmartin
Copy link
Owner

Opensearch-py phased out doc_type. Since it doesn't exist anymore, the fakes can't meaningfully support its old behavior. This process was going on in Elasticsearch-land too.

This I think is the first change I've made to the library that has any risk of breaking someone's build, so I'm noting it here in the issues.
@matthewdeanmartin matthewdeanmartin pinned this issue May 28, 2024
@matthewdeanmartin matthewdeanmartin changed the title 2.3.7 changes many function signatures because opensearch-py did (re: doc_type) doc_type is gone. 2.3.7 changes many function signatures because opensearch-py did (re: doc_type) May 28, 2024
@matthewdeanmartin matthewdeanmartin changed the title doc_type is gone. 2.3.7 changes many function signatures because opensearch-py did (re: doc_type) doc_type is gone. 2.3.7 changes many function signatures because opensearch-py did May 28, 2024
@matthewdeanmartin
Copy link
Owner Author

Fixed in 2.3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewdeanmartin