Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications are broken #12

Open
hanzei opened this issue May 28, 2020 · 0 comments
Open

Notifications are broken #12

hanzei opened this issue May 28, 2020 · 0 comments
Labels
Difficulty/3:Hard Hard ticket Hacktoberfest Help Wanted Community help wanted Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@hanzei
Copy link
Contributor

hanzei commented May 28, 2020

The cron job switch trigger all notifications is only started once when a user connects

mattermost-plugin-google-calendar/server/api.go

Line 131 in 51ee6ed

p.startCronJob(authedUserId)
. Hence, restarting the plugin also disables notifications.

A better way to implement this would be using https://pkg.go.dev/github.com/mattermost/[email protected]/cluster?tab=doc
@hanzei hanzei added Help Wanted Community help wanted Type/Bug Something isn't working Difficulty/3:Hard Hard ticket Up For Grabs Ready for help from the community. Removed when someone volunteers labels May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/3:Hard Hard ticket Hacktoberfest Help Wanted Community help wanted Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jespino @cpanato @hanzei