Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-128] Removed problematic security_opt: no-new-privileges #135

Closed
wants to merge 1 commit into from

Conversation

ZelnickB
Copy link

@ZelnickB ZelnickB commented Aug 2, 2023

Summary

This pull request removes the no-new-privileges security_opt from the services defined in the /docker-compose.yml file, as it causes errors when attempting to start the containers (see #128). Removing the security option seems to resolve the problem.

Ticket Link

Fixes #128

This commit removes the no-new-privileges security options from the services defined in the /docker-compose.yml file, as it causes errors when attempting to start the containers (see mattermost#128). Removing the security option seems to resolve the problem.
@hanzei hanzei requested a review from mrckndt March 4, 2024 12:32
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 4, 2024
@hanzei hanzei requested a review from mvitale1989 December 17, 2024 08:22
@mvitale1989
Copy link
Member

Thank you for contributing back the change @ZelnickB .
Removing the security options is not a best practice, because it opens up the possibility of permission escalation where superuser permissions should not be theoretically needed.
I'll reply in the original issue to help with the troubleshooting

@hanzei
Copy link

hanzei commented Dec 19, 2024

@mvitale1989 Can we close this PR then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation Not Permitted
3 participants