Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm): EVM simulator support – base #2979

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from
Draft

feat(vm): EVM simulator support – base #2979

wants to merge 65 commits into from

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Sep 27, 2024

What ❔

Modifies the Era codebase to support the EVM simulator. Intentionally avoids changing the contracts submodule yet; as a consequence, there are no EVM simulation tests.

Why ❔

Stepping stone for EVM equivalence.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

IAvecilla and others added 30 commits September 11, 2024 12:48
@IAvecilla
Make address optional in transaction data
bbd7db9
@IAvecilla
Add migrations and update queries with evm simulator
4e6bed2
@IAvecilla
Add evm simulator as base system contract and update callers
723c5e3
@IAvecilla
Add ts tests and contracts for evm simulator
3a3a300
@IAvecilla
Update multivm bootloaders bin files for vm1_5_0
8132132
@IAvecilla
Update lock file
6cae61a
@IAvecilla
Update contracts submodule
dfef5ea
@IAvecilla
Improve get contract address for sql queries
ddc35de
@IAvecilla
Merge branch 'main' into tx-to-optional-address
cf454e2
@IAvecilla
Make recipient address optional for L2Tx
a5c22ea
@IAvecilla
Fix error lints
c075fb4
@IAvecilla
Insert null in sql for contract address instead of empty bytes
6c94de9
@IAvecilla
Remove require and support None value for protobuff Transaction
b280eb3
@IAvecilla
Make address optional for Transaction recipient account
d49f3f8
@IAvecilla
Optionally add contract address to transaction signature
5e9179d
@IAvecilla
Check address is not null and reject transaction
0034e3e
@IAvecilla
Merge branch 'main' into tx-to-optional-address
d9e2b9a
@IAvecilla
Make test only Execute to always have a valid address instead of null
9c3dad1
@IAvecilla
Update execute use for tests in multivm crate to have a valid contrac…
9652368 
…t address
@IAvecilla
Update comment for optional field in execute proto message
189e591
@IAvecilla
Unwrap contract address for l1 tx since it should always be present
2ac399e
@IAvecilla
Merge branch 'main' into tx-to-optional-address
6be103f
@jrchatruc
Merge branch 'tx-to-optional-address' into evm-simulator-base-sc
9700ff3
@IAvecilla
Remove tests for the evm simulator
be77938
@jrchatruc
Merge remote-tracking branch 'upstream/main' into evm-simulator-base-sc
f8816cf
@IAvecilla
Delete contracts and aux functions used for evm tests
7608ace
@IAvecilla
Fix fmt
ed97d24
@IAvecilla @jrchatruc
feat: EVM simulator as optional for the server (#276)
f922068 
* Add evm simulator as optional for the server

* Changes to make it work against era-contracts `main`

* fmt

* Calculate bytecode of evm gas manager only if evm simulator flag is on

* Add multicall for get evm simulator bytecode hash

* Use bytecode of default account for the evm simulator if not present

* Remove unnecessary comments

* Use bytecode of default account for evm simulator in gas test sc

* Remove tests for the evm simulator

---------

Co-authored-by: Javier Chatruc <[email protected]>
@jrchatruc
Revert multivm bootloader change
2388ae8
@IAvecilla
Check for evm simulator to avoid failing for transactions with null c…
00f0324 
…ontract address
IAvecilla and others added 30 commits September 24, 2024 11:24
@IAvecilla
Merge branch 'main' into evm-simulator-base-sc
1385cb6
@IAvecilla
Fix doc comment for UseEvmSimulator config
9010c56
@IAvecilla
Remove evm simulator code hash from miniblocks table
774b848
@IAvecilla
Fix review comments
e85228b
@IAvecilla
Update sqlx cached queries
0f7c5da
@IAvecilla
Fix lints and format
b5c7544
@IAvecilla
Merge branch 'main' into evm-simulator-base-sc
9b0590d
@IAvecilla
Add evm simulator config to load config function
653b543
@IAvecilla
Add evm simulator to general test config and protobuf message
d2d61a4
@IAvecilla
Add use evm simulator config to general config file
44e714b
@slowli
Make EVM simulator optional
e4aee9b
@slowli
Remove garbage deps from multivm
a7d45b0
@slowli
Remove garbage deps from types
9b04a75
@slowli
Resolve some nits
613abae
@slowli
Change new_known_factory_deps type
5d21e75
@slowli
Revert changes in multivm unit tests
a80d649
@slowli
Remove UseEvmSimulator config
ff0b1e8
@slowli
Revert changes in config files
21ef547
@slowli
Sketch EVM simulator switch in API server
1a0c00c
@slowli
Disable EVM simulator for some tests
e63ac21
@slowli
Fix SQL queries with EVM simulator hash
6342503
@slowli
Fix creating_block_args_after_snapshot_recovery test
68e2647
@slowli
Load EVM simulator during genesis if appropriate
5a9b8e3
@slowli
Update from upstream
ee5f98f
@slowli
Remove unnecessary deps from contracts
8b05e37
@slowli
Return miniblocks.evm_simulator_code_hash
d0440aa 
It's necessary for blocks in the pending batch.
@slowli
Fix env config test
1828756
@slowli
Fix witness generator
41fa851
@slowli
Make EVM simulator optional in toolbox
d242f13
@slowli
Remove unused dependency
7784017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @IAvecilla @jrchatruc