feat: Add CoinMarketCap external API #2971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encody
changed the title
encody
commented
Sep 26, 2024
| // name: String, | ||
| // symbol: String, | ||
| // slug: String, | ||
| // is_active: u8, // TODO: This field is available, should we at least emit a warning if the listing is not marked as active? |
There was a problem hiding this comment.
Do we care to do "liveness" checks (i.e. could emit a warning if the API says that the token is inactive)?
There was a problem hiding this comment.
That's a good point - lets absolutely do it!
ischasny
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Looking good! Thank you for bringing CMC API over and brushing up wiring. While we are here - would it make sense to bring the tests over too?
Also, is CMC client repeating the error discovered by @cytadela8 (with flipped numerator / denominator)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds support for CoinMarketCap as a price API for base token prices.
Why ❔
Currently, the only supported API is CoinGecko. It's not ideal to only support a single 3rd party API here, so this provides some more degrees of freedom, and makes base token less reliant on a single third-party provider.
Checklist
zk fmtandzk lint.