-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide inclusion data as operator_da_input #2965
Merged
Merged
Commits on Sep 13, 2024
-
This PR changes the approach to managing 3rd party DA clients. It was assumed before that they will be stored in a separate repository (hyperchain-da), but to simplify the processes and solve a recursive dependency problem, we decided to manage those within `zksync-era`. The config now defines which DA client will be used, for proto-based configuration it requires adding these lines to general.yaml: ``` da_client: avail: api_node_url: wss://turing-rpc.avail.so/ws bridge_api_url: undefined seed: SEED_PHRASE app_id: 82 timeout: 3 max_retries: 5 ``` for env-based: ``` DA_CLIENT="Avail" DA_API_NODE_URL="localhost:12345" DA_BRIDGE_API_URL="localhost:54321" DA_SEED="SEED_PHRASE" DA_APP_ID=1 DA_TIMEOUT=2 DA_MAX_RETRIES=3 ``` If no config is provided - the default behavior is to use NoDA client (same as now). The `da_client` config might be merged with `da_dispatcher` at some point as the second depends on the first one, so their separation does not make much sense (apart from simplification of the configs). But I'd prefer to do it as a separate PR in case we decide to merge them. The client was reimplemented using only lightweight libraries from crates.io, so it doesn't have any visible impact on build time. To enable seamless integration with 3rd party DA clients in `zksync-era`. <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
Configuration menu - View commit details
-
Copy full SHA for f142ddc - Browse repository at this point
Copy the full SHA f142ddcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c20a03 - Browse repository at this point
Copy the full SHA 0c20a03View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 329730d - Browse repository at this point
Copy the full SHA 329730dView commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f04212b - Browse repository at this point
Copy the full SHA f04212bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c831f1 - Browse repository at this point
Copy the full SHA 9c831f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d41ff9f - Browse repository at this point
Copy the full SHA d41ff9fView commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48b186b - Browse repository at this point
Copy the full SHA 48b186bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e6470b - Browse repository at this point
Copy the full SHA 4e6470bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.