fix: fix state_diff_hash usage #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
changed the title
mm-zk
approved these changes
Sep 25, 2024
| @@ -1,8 +1,8 @@ | |||
| /// The key of the system log with value of the L2->L1 logs tree root hash | |||
| pub const L2_TO_L1_LOGS_TREE_ROOT_KEY: u32 = 0; | |||
|
|
|||
| /// The key of the system log with value of the state diff hash | |||
| pub const STATE_DIFF_HASH_KEY: u32 = 2; | |||
| /// The key of the system log with value of the state diff hash for pre-gateway protocol versions | |||
There was a problem hiding this comment.
what is in that slot AFTER gateway?
(did we move slot numbers or do we simply put empty data there)
There was a problem hiding this comment.
we've moved slots around, IIUC some were removed and some new were added. After gateway PREV_BATCH_HASH_KEY has key = 2
|
Merging cause I only added comments after approve. Feel free to leave additional comment, I can address them in next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
state_diff_hash,local_root,aggregated_rootoptional in L1BatchMetadatametadata.state_diff_hashis used for new batches, system log is used for old batchesWhy ❔
Checklist
zk fmtandzk lint.