feat: Expose http debug page #2952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
previously approved these changes
Sep 26, 2024
pompon0
reviewed
Sep 27, 2024
| @@ -41,10 +41,12 @@ pub fn get_consensus_config( | |||
|
|
|||
| let public_addr = SocketAddr::new(CONSENSUS_PUBLIC_ADDRESS_HOST, ports.consensus_port); | |||
| let server_addr = SocketAddr::new(CONSENSUS_SERVER_ADDRESS_HOST, ports.consensus_port); | |||
| let debug_page_addr = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 5000); | |||
There was a problem hiding this comment.
You shouldn't set a fixed port for the debug page. Please consult @Deniallugo on how to set it up correctly.
There was a problem hiding this comment.
exactly, it's better to introduce this port to the configs, otherwise, we will meet the port overlap
There was a problem hiding this comment.
I'd rather at it at least to the consensus config files
There was a problem hiding this comment.
ConsensusConfig is what is output from this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Exposes the consensus http debug on port 5000.
Fixes BFT-508