feat(vm): Split old and new VM implementations #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
Sep 18, 2024
joonazan
reviewed
Sep 23, 2024
core/lib/multivm/src/versions/vm_fast/tests/tester/transaction_test_info.rs
Outdated
Show resolved
Hide resolved
joonazan
approved these changes
Sep 23, 2024
joonazan
deleted the
aov-pla-1032-split-old-and-new-vm-implementations
branch
Deniallugo
pushed a commit
that referenced
this pull request
Sep 24, 2024
## What ❔ Splits old and new VM implementations in the `multivm` crate: - Old VMs are encapsulated in the `LegacyVmInstance` enum, while new ones in the `FastVmInstance` enum (which includes plain and shadowed VM variants). - Fast VM and `FastVmInstance` now expose a tracer type. - Usage of the Fast VM in the batch executor are updated correspondingly. ## Why ❔ It seems infeasible to unify the tracer model for old and new VMs, so keeping them all in a single enum makes little sense. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
🤖 I have created a release *beep* *boop* --- ## [24.27.0](core-v24.26.0...core-v24.27.0) (2024-09-25) ### Features * **vm:** Split old and new VM implementations ([#2915](#2915)) ([93bc66f](93bc66f)) ### Bug Fixes * **api:** Return correct flat call tracer ([#2917](#2917)) ([218646a](218646a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Splits old and new VM implementations in the
multivmcrate:LegacyVmInstanceenum, while new ones in theFastVmInstanceenum (which includes plain and shadowed VM variants).FastVmInstancenow expose a tracer type.Why ❔
It seems infeasible to unify the tracer model for old and new VMs, so keeping them all in a single enum makes little sense.
Checklist
zk fmtandzk lint.