Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zk_toolbox): add fees integration test to toolbox #2898

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

feat(zk_toolbox): add fees integration test to toolbox #2898

wants to merge 55 commits into from

Conversation

manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Sep 17, 2024 •
edited
Loading

What ❔

Add fees integration test to toolbox and CI.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Deniallugo Deniallugo force-pushed the manuel-add-ts-integration-fees-test-to-toolbox branch from 11b68b4 to 1ce733b Compare September 24, 2024 09:42
@Deniallugo
Fix
790e1a5 
Signed-off-by: Danil <[email protected]>
@Deniallugo
fix
f5cfc0d 
Signed-off-by: Danil <[email protected]>
@Deniallugo
Correct kill the process
f70e7d8 
Signed-off-by: Danil <[email protected]>
@Deniallugo Deniallugo force-pushed the manuel-add-ts-integration-fees-test-to-toolbox branch from 34226c1 to f70e7d8 Compare September 25, 2024 16:35
@Deniallugo
Reset pid
df0a451 
Signed-off-by: Danil <[email protected]>
@Deniallugo Deniallugo force-pushed the manuel-add-ts-integration-fees-test-to-toolbox branch from 7610e91 to 74e2951 Compare September 26, 2024 08:28
@Deniallugo Deniallugo marked this pull request as ready for review September 26, 2024 09:47
@Deniallugo Deniallugo requested a review from a team as a code owner September 26, 2024 09:47
sanekmelnikov
sanekmelnikov reviewed Sep 26, 2024
View reviewed changes
core/tests/ts-integration/src/context-owner.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/src/utils.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/src/utils.ts Outdated Show resolved Hide resolved
etc/utils/src/kill.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/tests/fees.test.ts Outdated Show resolved Hide resolved
core/tests/ts-integration/src/context-owner.ts Show resolved Hide resolved
core/tests/ts-integration/src/utils.ts Outdated Show resolved Hide resolved
@Deniallugo
Fix nits
f02b261 
Signed-off-by: Danil <[email protected]>
sanekmelnikov
sanekmelnikov previously approved these changes Sep 27, 2024
View reviewed changes
@Deniallugo
Fix logs place
fb31b2d 
Signed-off-by: Danil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo left review comments

@sanekmelnikov sanekmelnikov sanekmelnikov left review comments

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelmauro @sanekmelnikov @Deniallugo