Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zks_estimateFee test fails when run standalone #320

Closed
vbar opened this issue Aug 5, 2024 · 1 comment
Closed

zks_estimateFee test fails when run standalone #320

vbar opened this issue Aug 5, 2024 · 1 comment

Comments

@vbar
Copy link
Contributor

vbar commented Aug 5, 2024

🐛 Bug Report for zkSync Era In-Memory Node

📝 Description

Specifically the "Should return fee estimation data for transfer of 1 ETH" clause gets unexpected values. The test passes (as all tests pass) when run through make test-e2e.

🔄 Reproduction Steps

Run era test node as if for e2e tests, but instead of running all tests, switch to the e2e-tests directory and run npx hardhat test --grep zks_estimateFee.

🤔 Expected Behavior

The test should pass.

😯 Current Behavior

🖥️ Environment

  • Rust version: nightly-2024-01-01, as specified in rust-toolchain.toml
  • Operating System & Version: Ubuntu 20.04.6

📋 Additional Context

The interference is apparently from the "hardhat_impersonateAccount & hardhat_stopImpersonatingAccount" test, which switches system contracts to their impersonating variant (and doesn't call hardhat_stopImpersonatingAccount to switch them back), which probably affects fee calculations.

📎 Log Output

'''
e2e-tests$ npx hardhat test --grep zks_estimateFee

zks_estimateFee
1) Should return fee estimation data for transfer of 1 ETH

0 passing (158ms)
1 failing

  1. zks_estimateFee
    Should return fee estimation data for transfer of 1 ETH:

    Unexpected gas_limit

    • expected - actual

    {

    • "_hex": "0x598cb8"
    • "_hex": "0x3708d7"
      "_isBigNumber": true
      }

    at Context. (test/zks-apis.test.ts:33:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

@vbar vbar mentioned this issue Aug 15, 2024
@MexicanAce
Copy link
Collaborator

Resolved in #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants