Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrain from starting anvil-zksync instance after replay-tx #521

Open
dutterbutter opened this issue Jan 8, 2025 · 0 comments
Open

Refrain from starting anvil-zksync instance after replay-tx #521

dutterbutter opened this issue Jan 8, 2025 · 0 comments
Labels
good first issue 🐣 Good for newcomers (based on difficulty)

Comments

@dutterbutter
Copy link
Collaborator

dutterbutter commented Jan 8, 2025

Description

Currently when users make use of replaying a transaction, an instance of anvil-zksync is started there after.

Solution

Do not start an instance of anvil-zksync after replaying the transaction. Making it easier to review the details of the replayed transaction.

This would basically mean having node setup, executor spawned, and applying the replay transactions within:

Command::ReplayTx(replay_tx) => { ... }

And then exit. May need to think about refactoring main.rs before otherwise it would be a lot of redundant code between Command::ReplayTx and Command::Fork | Run.

@dutterbutter dutterbutter added the good first issue 🐣 Good for newcomers (based on difficulty) label Jan 8, 2025
@dutterbutter dutterbutter moved this to Todo in DevEx squad Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🐣 Good for newcomers (based on difficulty)
Projects
Status: Todo
Development

No branches or pull requests

1 participant