-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TouchScreen Laptops issue #335
Comments
@mirsadkosumi did you manage to solve this issue? i'm facing a similar problem with custom scroll while running FF 57; and apparently, none of these |
@cmnstmntmn Not really, had just to leave it like that for the moment. |
Still not solved in the latest version, try this demo page on a laptop with touch screen, Widows 10, Chrome. |
Change this line... SUPPORTS_TOUCH = 'ontouchstart' in window, to... SUPPORTS_TOUCH = ('ontouchstart' in document
|| 'ontouchstart' in window
|| window.TouchEvent
|| (window.DocumentTouch && document instanceof DocumentTouch)
|| navigator.maxTouchPoints > 0
|| navigator.msMaxTouchPoints > 0), That contains detection for Lenovo touchscreens, Chrome 70+, IE, and Firefox. |
I didn't have luck changing the After much experimentation, I managed to get both working at the same time: I simply doubled up the pointer events with touch events, e.g. |
@justinputney submit a PR with your fix please! |
@melloware done. |
I'm finding that the end event is not triggering in my code, so |
Another issue I'm seeing is the threshold. Touch gestures on Windows register much smaller move distances. I'm seeing values like 16, when the same swipe with the mouse pointer registers as 221. Also the touch distance seems to range from 15 to 19 no matter how far I swipe. |
Also, for some reason when using a touch gesture:
|
Would love to get your input on these items, @mattbryson as you're much more experience than I am. Is there a way to normalize the touch gesture distance? For now, I'm just going to set the threshold to 15 on Windows devices. |
Steps to resolve (in my case) and maintain history of patch:
Note: If it doesn't seem to be working, A) try adding Using some variation of the above, either as stated or in consecutive git commits to your main touchswipe file, you have a decent shot at getting this working and tracking the change so anyone knows what happened and doesn't lose it over time. (using comparison tools, the original can always be compared to the patched version) Hope it helps! Good luck! PS If you're having problems with swiping on your elements in general, try this...
|
I'm implementing TouchSwipe for an image slider.
And I am having this issue on TouchScreen Laptops, TouchSwipe doesn't recognize the mouse clicks or swipes, only touch taps or touch swipes are taking effect.
Same problem also while trying your demos - http://labs.rampinteractive.co.uk/touchSwipe/demos/index.html
Issue is being tested on Windows 10 with Chrome Version 62.0. (64-bit) and with Firefox 57.0 (64-bit), - while on Edge 41.1 it works perfectly just like it should.
Thanks in advance for your time :)
The text was updated successfully, but these errors were encountered: