From 75b020be181e39b64051bce78d8b1117daf932d9 Mon Sep 17 00:00:00 2001 From: Matt Brictson <matt@mattbrictson.com> Date: Thu, 1 Feb 2024 17:48:12 -0800 Subject: [PATCH] Remove recommendation for Capybara `disable_animation` (#40) Capybara's `disable_animation` option inserts a middleware that can conflict with other middleware, like `Rack::Deflater`. If removing animation is important for speeding up system tests, a more direct way to do it is to conditionally add CSS/JS to the application layout, rather rely on a middleware that could have unexpected side effects. Given the potential complications, I am removing `disable_animation` from the default Capybara config file that nextgen generates. --- template/test/support/capybara.rb.tt | 1 - 1 file changed, 1 deletion(-) diff --git a/template/test/support/capybara.rb.tt b/template/test/support/capybara.rb.tt index fdb8232..cbcf945 100644 --- a/template/test/support/capybara.rb.tt +++ b/template/test/support/capybara.rb.tt @@ -5,7 +5,6 @@ require "capybara/rspec" Capybara.configure do |config| config.default_max_wait_time = 2 - config.disable_animation = true config.enable_aria_label = true config.server = :puma, {Silent: true} config.test_id = "data-testid"