Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node JS 22 Support #9

Open
Tiuipuv opened this issue Oct 29, 2024 · 2 comments
Open

Node JS 22 Support #9

Tiuipuv opened this issue Oct 29, 2024 · 2 comments

Comments

@Tiuipuv
Copy link

Tiuipuv commented Oct 29, 2024

Hello matrus2,

Thanks for this repo! It provides great functionality, making ntlm auth in modern code bases very easy. However, because of the dependency on request, there is an issue with a sub dependency requiring in punycode. This is fixed if you migrate to a supported fork of request, @cypress/request (github link). Can you upgrade to @cypress/request v3.0.6 or higher?

@matrus2
Copy link
Owner

matrus2 commented Oct 30, 2024

Hi,

Thaks for looking into it. Do you mind to open the PR?

@Tiuipuv
Copy link
Author

Tiuipuv commented Nov 1, 2024

Thank you for the quick reply! I will look into getting one created in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants