Impact

URL previews of some web pages can exhaust the available stack space for the Synapse process due to unbounded recursion.
This is sometimes recoverable and leads to an error for the request causing the problem, but in other cases the Synapse process may crash altogether.

It is possible to exploit this maliciously, either by malicious users on the homeserver, or by remote users sending URLs that a local user's client may automatically request a URL preview for.
Remote users are not able to exploit this directly, because the URL preview endpoint is authenticated.

Am I affected?

• deployments with url_preview_enabled: false set in configuration are not affected.
• deployments with url_preview_enabled: true set in configuration are affected.
• deployments with no configuration value set for url_preview_enabled are not affected, because the default is false.

Patches

Administrators of homeservers with URL previews enabled are advised to upgrade to v1.61.1 or higher.

Workarounds

• URL previews can be disabled in the configuration file by setting url_preview_enabled: false.
• Deployments using workers can choose to offload URL previews to one or more dedicated worker(s), ensuring that a process crash does not disrupt other functionality of Synapse.

For more information

If you have any questions or comments about this advisory, e-mail us at [email protected].