Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor CPU spent in GC #224

Open
richvdh opened this issue May 7, 2021 · 0 comments
Open

monitor CPU spent in GC #224

richvdh opened this issue May 7, 2021 · 0 comments

Comments

@richvdh
Copy link
Member

richvdh commented May 7, 2021

by hooking into the gc callbacks, we could gather stats on the CPU time spent in the garbage collector (which I suspect is non-trivial), the frequency of garbage-collections, the number of objects being collected, etc.

Synapse currently does the same by disabling automatic GC and periodically running the GC manually https://github.com/matrix-org/synapse/blob/v1.33.0/synapse/metrics/__init__.py#L589) but I think we can achieve the same thing more elegantly via the callback hooks.

It would be nice to stick this in a library of prometheus extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant