Further review comments and formatting

Author: andybalaam

crates/matrix-sdk-crypto/src/store/memorystore.rs

@@ -161,7 +161,7 @@ impl MemoryStore {
         *self.private_identity.write().unwrap() = private_identity;
     }
 
-    /// Return all the ['InboundGroupSession']s we have, paired with the
+    /// Return all the [`InboundGroupSession`]s we have, paired with the
     /// `backed_up_to` value for each one (or "" where it is missing, which
     /// should never happen).
     async fn get_inbound_group_sessions_and_backed_up_to(
@@ -340,8 +340,9 @@ impl CryptoStore for MemoryStore {
                 .filter(|(_, o)| o.as_ref().is_some_and(|o| o.as_str() == backup_version))
                 .count()
         } else {
-            // We asked about a nonexistent backup version - this doesn't make much sense, but we
-            // can easily answer that nothing is backed up in this nonexistent backup.
+            // We asked about a nonexistent backup version - this doesn't make much sense,
+            // but we can easily answer that nothing is backed up in this
+            // nonexistent backup.
             0
         };
 
@@ -379,19 +380,21 @@ impl CryptoStore for MemoryStore {
         let mut inbound_group_sessions_backed_up_to =
             self.inbound_group_sessions_backed_up_to.write().unwrap();
 
-        for (room_id, session_id) in room_and_session_ids {
+        for &(room_id, session_id) in room_and_session_ids {
             let session = self.inbound_group_sessions.get(room_id, session_id);
+
             if let Some(session) = session {
                 session.mark_as_backed_up();
 
                 inbound_group_sessions_backed_up_to
-                    .entry((*room_id).to_owned())
+                    .entry(room_id.to_owned())
                     .or_default()
-                    .insert((*session_id).to_owned(), BackupVersion::from(backup_version));
+                    .insert(session_id.to_owned(), BackupVersion::from(backup_version));
 
                 self.inbound_group_sessions.add(session);
             }
         }
+
         Ok(())
     }
 
@@ -583,6 +586,7 @@ mod tests {
     use ruma::{room_id, user_id, RoomId};
     use vodozemac::{Curve25519PublicKey, Ed25519PublicKey};
 
+    use super::SessionId;
     use crate::{
         identities::device::testing::get_device,
         olm::{
@@ -592,8 +596,6 @@ mod tests {
         store::{memorystore::MemoryStore, Changes, CryptoStore, PendingChanges},
     };
 
-    use super::SessionId;
-
     #[async_test]
     async fn test_session_store() {
         let (account, session) = get_account_and_session_test_helper();