Merge pull request #4740 from matrix-org/travis/room-list/stability-1

Improve general stability in the new room list

Author: turt2live

src/components/structures/UserMenuButton.tsx

@@ -80,7 +80,7 @@ export default class UserMenuButton extends React.Component<IProps, IState> {
     private isUserOnDarkTheme(): boolean {
         const theme = SettingsStore.getValue("theme");
         if (theme.startsWith("custom-")) {
-            return getCustomTheme(theme.substring(0, 7)).is_dark;
+            return getCustomTheme(theme.substring("custom-".length)).is_dark;
         }
         return theme === "dark";
     }

src/stores/room-list/RoomListStoreTempProxy.ts

@@ -31,11 +31,14 @@ export class RoomListStoreTempProxy {
         return SettingsStore.isFeatureEnabled("feature_new_room_list");
     }
 
-    public static addListener(handler: () => void) {
+    public static addListener(handler: () => void): RoomListStoreTempToken {
         if (RoomListStoreTempProxy.isUsingNewStore()) {
-            return RoomListStore.instance.on(UPDATE_EVENT, handler);
+            const offFn = () => RoomListStore.instance.off(UPDATE_EVENT, handler);
+            RoomListStore.instance.on(UPDATE_EVENT, handler);
+            return new RoomListStoreTempToken(offFn);
         } else {
-            return OldRoomListStore.addListener(handler);
+            const token = OldRoomListStore.addListener(handler);
+            return new RoomListStoreTempToken(() => token.remove());
         }
     }
 
@@ -47,3 +50,12 @@ export class RoomListStoreTempProxy {
         }
     }
 }
+
+export class RoomListStoreTempToken {
+    constructor(private offFn: () => void) {
+    }
+
+    public remove(): void {
+        this.offFn();
+    }
+}

src/stores/room-list/TagWatcher.ts

@@ -74,6 +74,11 @@ export class TagWatcher {
                 this.store.removeFilter(filter);
             }
 
+            // Destroy any and all old filter conditions to prevent resource leaks
+            for (const filter of this.filters.values()) {
+                filter.destroy();
+            }
+
             this.filters = newFilters;
         }
     };