Remove labs setting for rust crypto

Author: richvdh

src/i18n/strings/en_EN.json

@@ -1465,11 +1465,6 @@
         "render_reaction_images_description": "Sometimes referred to as \"custom emojis\".",
         "report_to_moderators": "Report to moderators",
         "report_to_moderators_description": "In rooms that support moderation, the “Report” button will let you report abuse to room moderators.",
-        "rust_crypto": "Rust cryptography implementation",
-        "rust_crypto_in_config": "Rust cryptography cannot be disabled on this deployment of %(brand)s",
-        "rust_crypto_in_config_description": "Switching to the Rust cryptography requires a migration process that may take several minutes. It cannot be disabled; use with caution!",
-        "rust_crypto_optin_warning": "Switching to the Rust cryptography requires a migration process that may take several minutes. To disable you will need to log out and back in; use with caution!",
-        "rust_crypto_requires_logout": "Once enabled, Rust cryptography can only be disabled by logging out and in again",
         "sliding_sync": "Sliding Sync mode",
         "sliding_sync_description": "Under active development, cannot be disabled.",
         "sliding_sync_disabled_notice": "Log out and back in to disable",

src/settings/Settings.tsx

@@ -42,11 +42,9 @@ import { MetaSpace } from "../stores/spaces";
 import SdkConfig from "../SdkConfig";
 import SlidingSyncController from "./controllers/SlidingSyncController";
 import { FontWatcher } from "./watchers/FontWatcher";
-import RustCryptoSdkController from "./controllers/RustCryptoSdkController";
 import ServerSupportUnstableFeatureController from "./controllers/ServerSupportUnstableFeatureController";
 import { WatchManager } from "./WatchManager";
 import { CustomTheme } from "../theme";
-import SettingsStore from "./SettingsStore";
 import AnalyticsController from "./controllers/AnalyticsController";
 
 export const defaultWatchManager = new WatchManager();
@@ -479,24 +477,6 @@ export const SETTINGS: { [setting: string]: ISetting } = {
         description: _td("labs|oidc_native_flow_description"),
         default: false,
     },
-    [Features.RustCrypto]: {
-        // use the rust matrix-sdk-crypto-wasm for crypto.
-        isFeature: true,
-        labsGroup: LabGroup.Developer,
-        supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS_WITH_CONFIG,
-        displayName: _td("labs|rust_crypto"),
-        description: () => {
-            if (SettingsStore.getValueAt(SettingLevel.CONFIG, Features.RustCrypto)) {
-                // It's enabled in the config, so you can't get rid of it even by logging out.
-                return _t("labs|rust_crypto_in_config_description");
-            } else {
-                return _t("labs|rust_crypto_optin_warning");
-            }
-        },
-        shouldWarn: true,
-        default: true,
-        controller: new RustCryptoSdkController(),
-    },
     /**
      * @deprecated in favor of {@link fontSizeDelta}
      */

src/settings/controllers/RustCryptoSdkController.ts

@@ -15,13 +15,11 @@ limitations under the License.
 */
 
 import React from "react";
-import { render, screen, waitFor } from "@testing-library/react";
-import userEvent from "@testing-library/user-event";
+import { render, screen } from "@testing-library/react";
 
 import LabsUserSettingsTab from "../../../../../../src/components/views/settings/tabs/user/LabsUserSettingsTab";
 import SettingsStore from "../../../../../../src/settings/SettingsStore";
 import SdkConfig from "../../../../../../src/SdkConfig";
-import { SettingLevel } from "../../../../../../src/settings/SettingLevel";
 
 describe("<LabsUserSettingsTab />", () => {
     const defaultProps = {
@@ -63,105 +61,4 @@ describe("<LabsUserSettingsTab />", () => {
         const labsSections = container.getElementsByClassName("mx_SettingsSubsection");
         expect(labsSections).toHaveLength(10);
     });
-
-    describe("Rust crypto setting", () => {
-        const SETTING_NAME = "Rust cryptography implementation";
-
-        beforeEach(() => {
-            SdkConfig.add({ show_labs_settings: true });
-        });
-
-        describe("Not enabled in config", () => {
-            // these tests only works if the feature is not enabled in the config by default?
-            const copyOfGetValueAt = SettingsStore.getValueAt;
-
-            beforeEach(() => {
-                SettingsStore.getValueAt = (
-                    level: SettingLevel,
-                    name: string,
-                    roomId?: string,
-                    isExplicit?: boolean,
-                ) => {
-                    if (level == SettingLevel.CONFIG && name === "feature_rust_crypto") return false;
-                    return copyOfGetValueAt(level, name, roomId, isExplicit);
-                };
-            });
-
-            afterEach(() => {
-                SettingsStore.getValueAt = copyOfGetValueAt;
-            });
-
-            it("can be turned on if not already", async () => {
-                // By the time the settings panel is shown, `MatrixClientPeg.initClientCrypto` has saved the current
-                // value to the settings store.
-                await SettingsStore.setValue("feature_rust_crypto", null, SettingLevel.DEVICE, false);
-
-                const rendered = render(getComponent());
-                const toggle = rendered.getByRole("switch", { name: SETTING_NAME });
-                expect(toggle.getAttribute("aria-disabled")).toEqual("false");
-                expect(toggle.getAttribute("aria-checked")).toEqual("false");
-
-                const description = toggle.closest(".mx_SettingsFlag")?.querySelector(".mx_SettingsFlag_microcopy");
-                expect(description).toHaveTextContent(/To disable you will need to log out and back in/);
-            });
-
-            it("cannot be turned off once enabled", async () => {
-                await SettingsStore.setValue("feature_rust_crypto", null, SettingLevel.DEVICE, true);
-
-                const rendered = render(getComponent());
-                const toggle = rendered.getByRole("switch", { name: SETTING_NAME });
-                expect(toggle.getAttribute("aria-disabled")).toEqual("true");
-                expect(toggle.getAttribute("aria-checked")).toEqual("true");
-
-                // Hover over the toggle to make it show the tooltip
-                await userEvent.hover(toggle);
-
-                await waitFor(() => {
-                    const tooltip = screen.getByRole("tooltip");
-                    expect(tooltip).toHaveTextContent(
-                        "Once enabled, Rust cryptography can only be disabled by logging out and in again",
-                    );
-                });
-            });
-        });
-
-        describe("Enabled in config", () => {
-            beforeEach(() => {
-                SdkConfig.add({ features: { feature_rust_crypto: true } });
-            });
-
-            it("can be turned on if not already", async () => {
-                // By the time the settings panel is shown, `MatrixClientPeg.initClientCrypto` has saved the current
-                // value to the settings store.
-                await SettingsStore.setValue("feature_rust_crypto", null, SettingLevel.DEVICE, false);
-
-                const rendered = render(getComponent());
-                const toggle = rendered.getByRole("switch", { name: SETTING_NAME });
-                expect(toggle.getAttribute("aria-disabled")).toEqual("false");
-                expect(toggle.getAttribute("aria-checked")).toEqual("false");
-
-                const description = toggle.closest(".mx_SettingsFlag")?.querySelector(".mx_SettingsFlag_microcopy");
-                expect(description).toHaveTextContent(/It cannot be disabled/);
-            });
-
-            it("cannot be turned off once enabled", async () => {
-                await SettingsStore.setValue("feature_rust_crypto", null, SettingLevel.DEVICE, true);
-
-                const rendered = render(getComponent());
-                const toggle = rendered.getByRole("switch", { name: SETTING_NAME });
-                expect(toggle.getAttribute("aria-disabled")).toEqual("true");
-                expect(toggle.getAttribute("aria-checked")).toEqual("true");
-
-                // Hover over the toggle to make it show the tooltip
-                await userEvent.hover(toggle);
-
-                await waitFor(() => {
-                    const tooltip = rendered.getByRole("tooltip");
-                    expect(tooltip).toHaveTextContent(
-                        "Rust cryptography cannot be disabled on this deployment of BrandedClient",
-                    );
-                });
-            });
-        });
-    });
 });