Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Move db-level SQL statements to the file which implements the storage interface #963

Open
kegsay opened this issue Apr 14, 2020 · 2 comments
Open

Move db-level SQL statements to the file which implements the storage interface #963

kegsay opened this issue Apr 14, 2020 · 2 comments
Labels
good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@kegsay
Copy link
Member

kegsay commented Apr 14, 2020

In several places for postgres, we CREATE SEQUENCE .... We do this for every table which uses the sequence, partly for clarity and partly so we don't assume someone else has done it for us.

Instead, we should put these database-level SQL queries in a dedicated section, rather than in each _table.go.
@kegsay kegsay added maintenance good first issue Want to help with Dendrite? These are the issues to start with! labels Apr 14, 2020
This was referenced Apr 14, 2020
Closed
Closed
@mahadevans87
Copy link

Can I take this up? This would be my first issue in this project.

@kegsay kegsay added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. and removed maintenance labels Dec 5, 2022
@Shofiya2003
Copy link

Can I work on this issue?

This was referenced Oct 31, 2024
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mahadevans87 @kegsay @Shofiya2003