Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Dendrite needs to care about login flow ordering #708

Open
turt2live opened this issue May 28, 2019 · 2 comments
Open

Dendrite needs to care about login flow ordering #708

turt2live opened this issue May 28, 2019 · 2 comments
Labels
C-Client-API good first issue Want to help with Dendrite? These are the issues to start with! spec-compliance Fix something that doesn't comply with the specs T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@turt2live
Copy link
Member

See matrix-org/matrix-spec-proposals#2042

@anoadragon453 anoadragon453 added good first issue Want to help with Dendrite? These are the issues to start with! spec-compliance Fix something that doesn't comply with the specs labels May 30, 2019
@yesennes
Copy link

yesennes commented Sep 9, 2019

If I understand correctly, login flow ordering only applies to user-interactive authentication, which isn't implemented in Dendrite yet, at least according the comment in login.

If so this issue can't be completed at the moment until the much larger feature of user-interactive authentication. Maybe we should remove the good first issue tag then?

I'm just getting started and looking for a first issue, so correct me if I'm wrong about anything.

@turt2live
Copy link
Member Author

Login flows awkwardly don't apply to login (yet). They do apply to things which use User-Interactive Authentication (UIA) though - stuff like /register, /deactivate, and changing of passwords.

@kegsay kegsay added C-Client-API T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Client-API good first issue Want to help with Dendrite? These are the issues to start with! spec-compliance Fix something that doesn't comply with the specs T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

4 participants