Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Special case /register for application services #630

Open
2 tasks
babolivier opened this issue Jan 8, 2019 · 4 comments
Open
2 tasks

Special case /register for application services #630

babolivier opened this issue Jan 8, 2019 · 4 comments
Labels
C-App-Services C-Client-API good first issue Want to help with Dendrite? These are the issues to start with! spec-compliance Fix something that doesn't comply with the specs T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@babolivier
Copy link
Contributor

  • Allow an application service to register usernames starting with underscores if its configuration file allows it.
  • Support non-exclusive namespaces.

The latter means we shouldn't respond with Only 1 match allowed-like errors if a user ID provided during registration from an appservice matches more than one namespace and none of these namespaces is defined as exclusive. This requires checking whether a namespace is exclusive during registration.

@babolivier babolivier added C-Client-API good first issue Want to help with Dendrite? These are the issues to start with! spec-compliance Fix something that doesn't comply with the specs labels Jan 8, 2019
@MohitKS5
Copy link
Contributor

For the first part, should I assume that permission to use underscore will be implied by application service namespace 's regex or add a new parameter to config?

@rhymefororange
Copy link

rhymefororange commented Dec 10, 2021

Is this still an open issue? #1785 fixed the first part and #828 fixed the second, right? And #1599 mentions that #1784 is being used instead of this issue (which is closed).
Can someone clear up the confusion?

@rhymefororange
Copy link

@babolivier @kegsay any thoughts?

@kegsay
Copy link
Member

kegsay commented Jan 10, 2022

Unsure, I haven't been keeping track of appservice support. If the tests pass, then it should be ok to close, though I don't know which sytests relate to this issue.

@kegsay kegsay added C-App-Services T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-App-Services C-Client-API good first issue Want to help with Dendrite? These are the issues to start with! spec-compliance Fix something that doesn't comply with the specs T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

4 participants