Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Display Name of newly created user is replaced with the first person tries to communicate with them. #3324

Closed
lil5 opened this issue Feb 8, 2024 · 2 comments · Fixed by #3326
Labels
C-Roomserver O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@lil5
Copy link

lil5 commented Feb 8, 2024

Background information

  • Dendrite version or git SHA:
  • SQLite3 or Postgres?: Postgres
  • Running in Docker?: Yes
  • go version:
  • Client used (if applicable):

Description

  • What is the problem:
    Display Name of newly created user is replaced with the first person tries to communicate with them.
  • Who is affected:
    Any new user this is generated from the cmd
    On top of that this new user will be set as admin, even if the -admin flag is not used
  • How is this bug manifesting:
    The shared_secret_registration is shown as a device.
  • When did this first appear:
    After running /_synapse/admin/v1/register with a loggedin access token
ezgif-7-9342ddaa03.mov

Steps to reproduce

  1. Create a first user 1 using the cli register command with the username override
  2. Login user 1 in a client like Element
  3. Create a second user 2 using the cli register command with the username user
  4. With user 1 in Element chat with user 2
  5. Before sending a chat the displayname of user 2 is user
  6. Send a message to user 2
  7. The displayname of user 2 changes to override This should not happen, user 2 is also suddenly an admin.
@S7evinK S7evinK added C-Roomserver T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. S-Minor Blocks non-critical functionality, workarounds exist. O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Feb 8, 2024
@S7evinK
Copy link
Contributor

S7evinK commented Feb 8, 2024

I'm assuming you mean "room admin", right? That's the correct behavior when creating DMs.

@lil5
Copy link
Author

lil5 commented Feb 8, 2024

Ah right, the wording is naturally confusing, but I guess thats more an issue to take up with the client devs, nevertheless 3326 will fix the main issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Roomserver O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants