Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Complement flake TestPushSync/Adding_a_push_rule_wakes_up_an_incremental #3273

Closed
S7evinK opened this issue Nov 24, 2023 · 0 comments · Fixed by #3307
Closed

Complement flake TestPushSync/Adding_a_push_rule_wakes_up_an_incremental #3273

S7evinK opened this issue Nov 24, 2023 · 0 comments · Fixed by #3307
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures

Comments

@S7evinK
Copy link
Contributor

S7evinK commented Nov 24, 2023

Most recent: https://github.com/matrix-org/dendrite/actions/runs/6984545139/job/19007575361?pr=3078#step:7:123
@S7evinK S7evinK added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures labels Nov 24, 2023
@S7evinK S7evinK mentioned this issue Nov 24, 2023
Merged
@S7evinK S7evinK mentioned this issue Jan 18, 2024
Merged
S7evinK added a commit that referenced this issue Jan 20, 2024
@S7evinK
Don't send device list updates upon registration (#3307)
d357615 
Fixes #3273

As we otherwise send down device list updates which are merely useful
for the user and causes tests to be flakey:

```
❌ TestPushSync/Adding_a_push_rule_wakes_up_an_incremental_/sync (10ms)
      push_test.go:57: no pushrules found in sync response: {"next_batch":"s0_0_0_0_0_1_1_0_1","device_lists":{"changed":["@user-1:hs1"]}}
```

What this does: If a `PerformDeviceCreation` request is coming from
registering an account, it does **not** send device list updates, as
they are merely useful (no joined rooms, no one to inform) . In all
other cases, the behavior is unchanged and device list updates are sent
as usual.
@matrixbot matrixbot mentioned this issue Nov 1, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't send device list updates upon registration matrix-org/dendrite
1 participant
@S7evinK