Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add small tests and improvement for mpl-use-full-test-name #114

Closed
wants to merge 16 commits into from
Closed

Add small tests and improvement for mpl-use-full-test-name #114

wants to merge 16 commits into from

Conversation

theRealSuperMario
Copy link

Adds small section on mpl-use-full-test-name option

Close #85

@theRealSuperMario
Update Readme
4d8360f
@theRealSuperMario
Add test_use_full_name
f94b9da 
- test_success
- test_missing_hash
- test_incorrect_hash
@theRealSuperMario theRealSuperMario changed the title Update Readme Add small tests and improvement for mpl-use-full-test-name Mar 7, 2021
@theRealSuperMario theRealSuperMario mentioned this pull request Mar 7, 2021
Closed
@theRealSuperMario
Copy link
Author

@astrofrog

I am having quite a hard time getting test_hash_succeeds to work. I noticed that it wouldn't run even when using the plane master. Do you have an idea what I might be missing?

ConorMacBride
ConorMacBride reviewed May 18, 2023
View reviewed changes
Copy link
Member

@ConorMacBride ConorMacBride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @theRealSuperMario, sorry for the delay in reviewing this PR. I'm more active here now, so if you have any other PRs or issues, I'll be sure to get back sooner.

As mentioned in #116, I think it's best not to add the wrapping. The mpl-use-full-test-name option has now been documented as part of a documentation rewrite.

This config option doesn't currently have tests, so the tests would be great! As far as I remember, this option should not affect hashes, so I don't think we need the new hash tests here? As it's been a while, I'll close this PR, but feel free to open a PR with tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConorMacBride ConorMacBride ConorMacBride left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support hierarchical tests
2 participants
@theRealSuperMario @ConorMacBride