Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]: logo example should include dark option and have names #25537

Open
jklymak opened this issue Mar 23, 2023 · 3 comments
Open

[Doc]: logo example should include dark option and have names #25537

jklymak opened this issue Mar 23, 2023 · 3 comments

Comments

@jklymak
Copy link
Member

jklymak commented Mar 23, 2023

Documentation Link

https://github.com/matplotlib/matplotlib/blob/main/galleries/examples/misc/logos2.py

Problem

We now have a dark version that should be in the logo example as a toggle.

The logo example should have "logo_light.svg" and "logo_dark.svg" somewhere in the text so its searchable by the name of the files that get used in the site logo.

See matplotlib/mpl-sphinx-theme#62

@kindler-king
Copy link

Hello @jklymak, I just came across this issue and looked at the links you shared.
Do we want to add a new example altogether to highlight the creation of the dark mode logo too ?
Or should just having textual reference to suggest the existence of a dark themed logo do the trick?

@jklymak
Copy link
Member Author

jklymak commented Apr 5, 2023

I'd have the example make both logos.

@kindler-king
Copy link

Hello @jklymak , is this what you had in mind?
I have added a new parameter to the make_logo method called 'mode' which can be used to generate 2 different kinds of logo both the "logo_light.svg" and "logo_dark.svg" mainly because the hexcode color for the logo_light.svg was hard coded in the example.

We can incorporte this new example as seen in the screenshot to the matplotlib logo example, if you feel this seems good enough.

Screenshot from 2023-04-10 17-05-58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants