Delete server doesn't remove it from configuration file

[ghost]

When I delete a server from the list, the corresponding section in the config.ini.php file is still present.

[sgiehl]

Hi @tbowan. I'm able to reproduce this one. The server is actually removed from the list of servers in config, but the config section for this server remains. Guess in this method we would need to check, which servers were configured before and also remove the config sections for those that shouldn't exist any longer:

plugin-LoginLdap/Config.php

Lines 284 to 295 in 582d2d4

	public static function saveLdapServerConfigs($servers)
	{
	$serverNames = array();
	foreach ($servers as $serverInfo) {
	ServerInfo::saveServerConfig($serverInfo, $forceSave = false);
	$serverNames[] = $serverInfo['name'];
	}
	PiwikConfig::getInstance()->LoginLdap['servers']= $serverNames;
	PiwikConfig::getInstance()->forceSave();
	}