-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How about adding more device types? #7544
Comments
I'm not against. |
It would be nice. |
As long as we only introduce sub types we can do that any time. But we should avoid changing the existing types. If that would be required we need to release a new major version for that. |
There are #7488, #7487, #7489 and potentially #7491 that would benefit from a major release. I wanted to address those in respectful PRs, but I got myself into going through brands (898 parsed) and I have also found at least 91 "issues" (wrong cases in names, entirely wrong brands, incomplete names, etc.), so I thought to finish those first. Then there is a new #7571 I've just raised, that we probably need to find a solution for. Why I think it's better to have new types? Well, at the least projectors are not TVs, they are not even close, even though you do get an image in the end, ebook readers are not necessarily tablets, there are those the size of a phone, too, and headsets and glasses are definitely not related to watches. In addition, it may be a good idea to think of a way to allow frictionless addition of new types of the devices, too. It would be more straightforward to maintain that in the long run compared to maintaining a list of sub types, where we may start debating whether a device is type A or type B (like Apple Vision: is it glasses or peripheral or "PC"?). |
I suggest adding sub device types (sub-types will not affect the current baseline result, but will give specifics about the type of device):
smartphone
orperipheral
smartphone
ortable
orperipheral
for those who use the
device.type
will not change anything.if there is a subtype, it will be returned to
device.sub_type
What do you think about this idea?
The text was updated successfully, but these errors were encountered: